Update prefservice only if it is available.

Update prefservice only if it is available.

Update pref service before showing the interstitial only if it is available. Also
remove an unused method.

BUG=

Review-Url: https://codereview.chromium.org/2627343003
Cr-Commit-Position: refs/heads/master@{#443456}
Committed: https://chromium.googlesource.com/chromium/src/+/af129d5cac6eb18cb4472717e72fe84a9a11c8c6

[sgurun-gerrit only, 2017-01-12 23:25:19]

Description was changed from

==========
Update prefservice only if it is available.

Update pref service before showing the interstitial only if it is available.
Also
remove an unused method.

BUG=
==========

to

==========
Update prefservice only if it is available.

Update pref service before showing the interstitial only if it is available.
Also
remove an unused method.

BUG=
==========

[sgurun-gerrit only, 2017-01-12 23:25:19]

sgurun@chromium.org changed reviewers:
+ meacer@chromium.org

[sgurun-gerrit only, 2017-01-12 23:25:39]

On 2017/01/12 23:25:19, sgurun wrote:
> mailto:sgurun@chromium.org changed reviewers:
> + mailto:meacer@chromium.org

ptal, thanks

[sgurun-gerrit only, 2017-01-12 23:25:46]

The CQ bit was checked by sgurun@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meacer, 2017-01-12 23:37:12]

Lgtm, but a bug number would be useful too :)

https://codereview.chromium.org/2627343003/diff/1/components/security_interst...
File components/security_interstitials/content/security_interstitial_page.cc
(right):

https://codereview.chromium.org/2627343003/diff/1/components/security_interst...
components/security_interstitials/content/security_interstitial_page.cc:38: if
(controller_->GetPrefService()) {
nit: In which cases can this be null? Might be useful to add a comment about
that.

[sgurun-gerrit only, 2017-01-12 23:52:54]

added a bug number too.

https://codereview.chromium.org/2627343003/diff/1/components/security_interst...
File components/security_interstitials/content/security_interstitial_page.cc
(right):

https://codereview.chromium.org/2627343003/diff/1/components/security_interst...
components/security_interstitials/content/security_interstitial_page.cc:38: if
(controller_->GetPrefService()) {
On 2017/01/12 23:37:12, Mustafa Emre Acer wrote:
> nit: In which cases can this be null? Might be useful to add a comment about
> that.

Done.

[sgurun-gerrit only, 2017-01-12 23:53:01]

The CQ bit was checked by sgurun@chromium.org

[sgurun-gerrit only, 2017-01-12 23:53:02]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2627343003/#ps20001
(title: "address code review")

[commit-bot: I haz the power, 2017-01-12 23:54:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:57:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484265181758710,
"parent_rev": "f13062d9f24f77c0262ec3ad3734c63c65c1bbe6", "commit_rev":
"af129d5cac6eb18cb4472717e72fe84a9a11c8c6"}

[commit-bot: I haz the power, 2017-01-13 01:57:33]

Description was changed from

==========
Update prefservice only if it is available.

Update pref service before showing the interstitial only if it is available.
Also
remove an unused method.

BUG=
==========

to

==========
Update prefservice only if it is available.

Update pref service before showing the interstitial only if it is available.
Also
remove an unused method.

BUG=

Review-Url: https://codereview.chromium.org/2627343003
Cr-Commit-Position: refs/heads/master@{#443456}
Committed:
https://chromium.googlesource.com/chromium/src/+/af129d5cac6eb18cb4472717e72f...
==========

[commit-bot: I haz the power, 2017-01-13 01:57:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/af129d5cac6eb18cb4472717e72f...