Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2627323004: Add raymes@ and benwells@ as c/b/geolocation owners. (Closed)

Created:
3 years, 11 months ago by benwells
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add raymes@ and benwells@ as c/b/geolocation owners. This code is mostly permissions related, and most changes related to the handling of permissions and content settings. BUG=None Review-Url: https://codereview.chromium.org/2627323004 Cr-Commit-Position: refs/heads/master@{#443532} Committed: https://chromium.googlesource.com/chromium/src/+/63cfac9f60276d84701f8afe7ca1603f2ae1e575

Patch Set 1 #

Patch Set 2 : Actually add benwells #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/geolocation/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
benwells
Hey Scott - is this what you had in mind?
3 years, 11 months ago (2017-01-12 21:09:27 UTC) #2
benwells
Michael / Tim - are you ok with raymes@ and myself@ becoming c/b/geo owners? Most ...
3 years, 11 months ago (2017-01-12 21:18:42 UTC) #4
Michael van Ouwerkerk
lgtm thanks for taking this on!
3 years, 11 months ago (2017-01-13 10:07:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627323004/20001
3 years, 11 months ago (2017-01-13 11:20:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/63cfac9f60276d84701f8afe7ca1603f2ae1e575
3 years, 11 months ago (2017-01-13 11:29:53 UTC) #10
timvolodine
3 years, 11 months ago (2017-01-13 15:47:48 UTC) #11
Message was sent while issue was closed.
On 2017/01/13 11:29:53, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/63cfac9f60276d84701f8afe7ca1...

lgtm here as well, thanks!

Powered by Google App Engine
This is Rietveld 408576698