Expose font and color of the main and secondary texts in CollectionViewTextItem

Expose font and color of the main and secondary texts in CollectionViewTextItem

Review-Url: https://codereview.chromium.org/2627323003
Cr-Commit-Position: refs/heads/master@{#443582}
Committed: https://chromium.googlesource.com/chromium/src/+/07db4ac1a48f0ebb1ff520d8ae07a550f326a399

[Moe, 2017-01-12 19:45:08]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[Moe, 2017-01-12 19:45:44]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org

[Moe, 2017-01-12 19:45:45]

Hi Louis, please take a look.

[commit-bot: I haz the power, 2017-01-12 19:45:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 19:57:31]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-01-13 10:13:27]

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
File ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h
(right):

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h:28: //
The font of the main text.
Add to these comments which default value is used.

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h:29:
@property(nonatomic, copy) UIFont* textFont;
Also add the null_resettable attribute if you implement my last comment.

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
File ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm
(right):

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm:38: -
(void)setTextFont:(UIFont*)textFont {
Could you do something like this:

- (UIFont*)textFont {
  if (!_textFont) {
    _textFont = [[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];
  }
  return _textFont;
}

That way the default value can be reset easily by setting textFont to nil (which
is exactly the behavior of a null_resettable property).

[Moe, 2017-01-13 15:28:01]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 15:28:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-01-13 15:28:20]

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
File ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h
(right):

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h:28: //
The font of the main text.
On 2017/01/13 10:13:26, lpromero wrote:
> Add to these comments which default value is used.

Done.

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h:29:
@property(nonatomic, copy) UIFont* textFont;
On 2017/01/13 10:13:26, lpromero wrote:
> Also add the null_resettable attribute if you implement my last comment.

Done. Adding null_resettable to these properties requires nullability type
specifiers to be added to all the other properties too. I added nullable to
those.

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
File ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm
(right):

https://codereview.chromium.org/2627323003/diff/1/ios/chrome/browser/ui/colle...
ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm:38: -
(void)setTextFont:(UIFont*)textFont {
On 2017/01/13 10:13:26, lpromero wrote:
> Could you do something like this:
> 
> - (UIFont*)textFont {
>   if (!_textFont) {
>     _textFont = [[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];
>   }
>   return _textFont;
> }
> 
> That way the default value can be reset easily by setting textFont to nil
(which
> is exactly the behavior of a null_resettable property).

Done.

[lpromero, 2017-01-13 15:35:13]

The CQ bit was unchecked by lpromero@chromium.org

[lpromero, 2017-01-13 15:35:20]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-01-13 15:35:20]

lgtm

[commit-bot: I haz the power, 2017-01-13 15:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 15:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 15:40:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Moe, 2017-01-13 16:41:22]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2017-01-13 16:41:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 16:52:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484325682302920,
"parent_rev": "cc44547a90acfb170c5a52be637009c6940745ca", "commit_rev":
"07db4ac1a48f0ebb1ff520d8ae07a550f326a399"}

[commit-bot: I haz the power, 2017-01-13 16:53:33]

Description was changed from

==========
Expose font and color of the main and secondary texts in CollectionViewTextItem
==========

to

==========
Expose font and color of the main and secondary texts in CollectionViewTextItem

Review-Url: https://codereview.chromium.org/2627323003
Cr-Commit-Position: refs/heads/master@{#443582}
Committed:
https://chromium.googlesource.com/chromium/src/+/07db4ac1a48f0ebb1ff520d8ae07...
==========

[commit-bot: I haz the power, 2017-01-13 16:53:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/07db4ac1a48f0ebb1ff520d8ae07...