Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2627323002: Revert of Stop bad results on first memory benchmark run (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/memory.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health.py
diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py
index 75a688132d0dc67786a4f7aebe94736de9c0540e..80539198fbdae81ca5f10c974cd12e7aa9ab8b62 100644
--- a/tools/perf/benchmarks/system_health.py
+++ b/tools/perf/benchmarks/system_health.py
@@ -105,15 +105,6 @@
return page_sets.SystemHealthStorySet(platform=self.PLATFORM,
take_memory_measurement=True)
- def SetExtraBrowserOptions(self, options):
- # Just before we measure memory we flush the system caches
- # unfortunately this doesn't immediately take effect, instead
- # the next story run is effected. Due to this the first story run
- # has anomalous results. This option causes us to flush caches
- # each time before Chrome starts so we effect even the first story
- # - avoiding the bug.
- options.clear_sytem_cache_for_browser_and_profile_on_start = True
-
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return True
« no previous file with comments | « tools/perf/benchmarks/memory.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698