Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2627283002: Media Session: add [SameObject] on navigator.mediaSession. (Closed)

Created:
3 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Session: add [SameObject] on navigator.mediaSession. This is a no-op for our bindings but it keeps us in sync with the spec. BUG=None R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2627283002 Cr-Commit-Position: refs/heads/master@{#443371} Committed: https://chromium.googlesource.com/chromium/src/+/d1d309e714ab00913816fbf28034d9d71d697180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
mlamouri (slow - plz ping)
PTAL
3 years, 11 months ago (2017-01-12 15:54:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627283002/1
3 years, 11 months ago (2017-01-12 17:26:18 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-12 17:26:20 UTC) #9
mlamouri (slow - plz ping)
On 2017/01/12 at 17:25:48, zqzhang wrote: > The CQ bit was checked by zqzhang@chromium.org You ...
3 years, 11 months ago (2017-01-12 17:30:44 UTC) #10
Zhiqiang Zhang (Slow)
lgtm
3 years, 11 months ago (2017-01-12 21:28:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627283002/1
3 years, 11 months ago (2017-01-12 21:29:41 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:39:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1d309e714ab00913816fbf28034...

Powered by Google App Engine
This is Rietveld 408576698