Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2627263002: MD History: Remove unnecessary namespacing from tests (part 2) (Closed)

Created:
3 years, 11 months ago by tsergeant
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove unnecessary namespacing from tests (part 2) These files define test cases inside a dedicated `registerTests` function. This no longer has any benefit for isolating tests, and just reduces the amount of horizontal space available for test code. This CL only removes these registerTests functions and deindents the corresponding code -- there are no functional changes to any tests. BUG=647115 Review-Url: https://codereview.chromium.org/2627263002 Cr-Commit-Position: refs/heads/master@{#443380} Committed: https://chromium.googlesource.com/chromium/src/+/1a17a732d52a25fc250243aa4b968de6b3d50739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -456 lines) Patch
M chrome/test/data/webui/md_history/browser_service_test.js View 1 chunk +18 lines, -28 lines 0 comments Download
M chrome/test/data/webui/md_history/history_drawer_test.js View 1 chunk +19 lines, -27 lines 0 comments Download
M chrome/test/data/webui/md_history/history_grouped_list_test.js View 1 chunk +280 lines, -293 lines 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 1 chunk +97 lines, -104 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tsergeant
PTAL!
3 years, 11 months ago (2017-01-12 06:01:33 UTC) #6
Dan Beam
lgtm
3 years, 11 months ago (2017-01-12 20:07:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627263002/1
3 years, 11 months ago (2017-01-12 22:00:38 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 22:08:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a17a732d52a25fc250243aa4b96...

Powered by Google App Engine
This is Rietveld 408576698