Rename LayoutTests/imported/ -> LayoutTests/external/.

Rename LayoutTests/imported/ -> LayoutTests/external/.

Reason: The name "imported" may lead people to believe that it's intended to be a "read-only" copy of the tests.

This initial upload to Rietveld includes some changes, but doesn't
actually include the directory move or any other changes in LayoutTests,
since that makes the CL too large to upload.

This CL would have to be tested locally and landed directly. :-/

BUG=678788
R=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2627213003 .
Cr-Commit-Position: refs/heads/master@{#444194}
Committed: https://chromium.googlesource.com/chromium/src/+/6506b8b80db745936336bb88855cd078c083691e

[qyearsley, 2017-01-12 19:37:15]

Description was changed from

==========
Rename LayoutTests/imported/ -> LayoutTests/external/.

This initial upload to Rietveld includes some changes, but doesn't
actually include the directory move or any other changes in LayoutTests,
since that makes the CL too large to upload. If this is OK, then this
CL would have to be landed directly.

BUG=678788
==========

to

==========
Rename LayoutTests/imported/ -> LayoutTests/external/.

Reason: The name "imported" may lead people to believe that it's intended to be
a "read-only" copy of the tests.

This initial upload to Rietveld includes some changes, but doesn't
actually include the directory move or any other changes in LayoutTests,
since that makes the CL too large to upload.

This CL would have to be tested locally and landed directly. :-/

BUG=678788
==========

[qyearsley, 2017-01-12 19:37:15]

qyearsley@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2017-01-17 16:49:24]

LGTM

Since you'll be submitting manually, please just verify that the tests still
pass and (either before landing or immediately after) that imports can still
succeed alright.

[qyearsley, 2017-01-17 22:19:41]

On 2017/01/17 at 16:49:24, rbyers wrote:
> LGTM
> 
> Since you'll be submitting manually, please just verify that the tests still
pass and (either before landing or immediately after) that imports can still
succeed alright.

Will now try to land this

[qyearsley, 2017-01-17 23:05:46]

On 2017/01/17 at 22:19:41, qyearsley wrote:
> On 2017/01/17 at 16:49:24, rbyers wrote:
> > LGTM
> > 
> > Since you'll be submitting manually, please just verify that the tests still
pass and (either before landing or immediately after) that imports can still
succeed alright.
> 
> Will now try to land this

Now trying to make sure everything works before landing; there are some
csswg-test tests that behave differently locally, so now investigating that
before trying to land.

[tkent, 2017-01-17 23:11:09]

On 2017/01/17 at 23:05:46, qyearsley wrote:
> 
> Now trying to make sure everything works before landing; there are some
csswg-test tests that behave differently locally, so now investigating that
before trying to land.

I guess you need to update components/test_runner/test_interfaces.cc and
content/shell/renderer/layout_test/blink_test_runner.cc.

[qyearsley, 2017-01-17 23:42:22]

On 2017/01/17 at 23:11:09, tkent wrote:
> On 2017/01/17 at 23:05:46, qyearsley wrote:
> > 
> > Now trying to make sure everything works before landing; there are some
csswg-test tests that behave differently locally, so now investigating that
before trying to land.
> 
> I guess you need to update components/test_runner/test_interfaces.cc and
content/shell/renderer/layout_test/blink_test_runner.cc.

That was it! Thanks :-)

[qyearsley, 2017-01-17 23:52:47]

Description was changed from

==========
Rename LayoutTests/imported/ -> LayoutTests/external/.

Reason: The name "imported" may lead people to believe that it's intended to be
a "read-only" copy of the tests.

This initial upload to Rietveld includes some changes, but doesn't
actually include the directory move or any other changes in LayoutTests,
since that makes the CL too large to upload.

This CL would have to be tested locally and landed directly. :-/

BUG=678788
==========

to

==========
Rename LayoutTests/imported/ -> LayoutTests/external/.

Reason: The name "imported" may lead people to believe that it's intended to be
a "read-only" copy of the tests.

This initial upload to Rietveld includes some changes, but doesn't
actually include the directory move or any other changes in LayoutTests,
since that makes the CL too large to upload.

This CL would have to be tested locally and landed directly. :-/

BUG=678788
R=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2627213003 .
Cr-Commit-Position: refs/heads/master@{#444194}
Committed:
https://chromium.googlesource.com/chromium/src/+/6506b8b80db745936336bb88855c...
==========

[qyearsley, 2017-01-17 23:52:48]

Committed patchset #1 (id:1) manually as
6506b8b80db745936336bb88855cd078c083691e.

[qyearsley, 2017-01-18 00:01:08]

On 2017/01/17 at 23:52:48, qyearsley wrote:
> Committed patchset #1 (id:1) manually as
6506b8b80db745936336bb88855cd078c083691e.

A bit scary to commit such a big patch manually. Will now run importer and watch
waterfall.

[qyearsley, 2017-01-18 00:07:40]

On 2017/01/18 at 00:01:08, qyearsley wrote:
> On 2017/01/17 at 23:52:48, qyearsley wrote:
> > Committed patchset #1 (id:1) manually as
6506b8b80db745936336bb88855cd078c083691e.
> 
> A bit scary to commit such a big patch manually. Will now run importer and
watch waterfall.

Update: looks like I missed some changes in LayoutTests/virtual.