Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: Source/core/platform/graphics/skia/FontCacheSkia.cpp

Issue 26272006: Fix Skia FontCache platform data construction to use right font size (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/platform/linux/fast/forms/placeholder-position-expected.png ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (c) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 12 matching lines...) Expand all
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 32
33 #include "RuntimeEnabledFeatures.h"
33 #include "SkFontMgr.h" 34 #include "SkFontMgr.h"
34 #include "SkTypeface.h" 35 #include "SkTypeface.h"
35 #include "platform/NotImplemented.h" 36 #include "platform/NotImplemented.h"
36 #include "core/platform/graphics/Font.h" 37 #include "core/platform/graphics/Font.h"
37 #include "core/platform/graphics/FontCache.h" 38 #include "core/platform/graphics/FontCache.h"
38 #include "core/platform/graphics/FontDescription.h" 39 #include "core/platform/graphics/FontDescription.h"
39 #include "core/platform/graphics/SimpleFontData.h" 40 #include "core/platform/graphics/SimpleFontData.h"
40 #include "wtf/Assertions.h" 41 #include "wtf/Assertions.h"
41 #include "wtf/text/AtomicString.h" 42 #include "wtf/text/AtomicString.h"
42 #include "wtf/text/CString.h" 43 #include "wtf/text/CString.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 #if !OS(WIN) 161 #if !OS(WIN)
161 FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontD escription, const AtomicString& family) 162 FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontD escription, const AtomicString& family)
162 { 163 {
163 CString name; 164 CString name;
164 SkTypeface* tf = createTypeface(fontDescription, family, name); 165 SkTypeface* tf = createTypeface(fontDescription, family, name);
165 if (!tf) 166 if (!tf)
166 return 0; 167 return 0;
167 168
168 FontPlatformData* result = new FontPlatformData(tf, 169 FontPlatformData* result = new FontPlatformData(tf,
169 name.data(), 170 name.data(),
170 fontDescription.computedSize(), 171 (RuntimeEnabledFeatures::subpixelFontScalingEnabled())
172 ? fontDescription.computedSize()
173 : fontDescription.computedPixelSize(),
171 fontDescription.weight() >= FontWeightBold && !tf->isBold(), 174 fontDescription.weight() >= FontWeightBold && !tf->isBold(),
172 fontDescription.italic() && !tf->isItalic(), 175 fontDescription.italic() && !tf->isItalic(),
173 fontDescription.orientation()); 176 fontDescription.orientation());
174 tf->unref(); 177 tf->unref();
175 return result; 178 return result;
176 } 179 }
177 #endif // !OS(WINDOWNS) 180 #endif // !OS(WINDOWNS)
178 181
179 } // namespace WebCore 182 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/platform/linux/fast/forms/placeholder-position-expected.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698