Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 2627163003: Re-enable hackernews telemetry test on linux. (Closed)

Created:
3 years, 11 months ago by sunyunjia
Modified:
3 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable hackernews telemetry test on linux. Previously, we disabled the hackernews telemetry test as we tried to set the default value of touch-events flag to enabled. Now we've changed the strategy and reset the default value to auto. And recently, we also passed the test with the flag set to be enabled. So the hackernews telemetry test no longer needs to be disabled. BUG=665007 Review-Url: https://codereview.chromium.org/2627163003 Cr-Commit-Position: refs/heads/master@{#443227} Committed: https://chromium.googlesource.com/chromium/src/+/20b0d38e48ac6294d88377f1b09fbd54eb7704f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
sunyunjia
PTAL, thanks!
3 years, 11 months ago (2017-01-12 14:30:02 UTC) #12
nednguyen
Thanks a lot for doing the extra work to reenable test! lgtm
3 years, 11 months ago (2017-01-12 14:33:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627163003/1
3 years, 11 months ago (2017-01-12 14:34:05 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 14:39:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20b0d38e48ac6294d88377f1b09f...

Powered by Google App Engine
This is Rietveld 408576698