|
|
DescriptionRe-enable hackernews telemetry test on linux.
Previously, we disabled the hackernews telemetry test as we tried to set the
default value of touch-events flag to enabled. Now we've changed the strategy
and reset the default value to auto. And recently, we also passed the test with
the flag set to be enabled. So the hackernews telemetry test no longer needs to
be disabled.
BUG=665007
Review-Url: https://codereview.chromium.org/2627163003
Cr-Commit-Position: refs/heads/master@{#443227}
Committed: https://chromium.googlesource.com/chromium/src/+/20b0d38e48ac6294d88377f1b09fbd54eb7704f4
Patch Set 1 #
Messages
Total messages: 18 (14 generated)
Description was changed from ========== Re-enable hackernews telemetry test on linux. BUG=665007 ========== to ========== Re-enable hackernews telemetry test on linux. Previously, we disabled the hackernews telemetry test as we tried to set the default value of touch-events flag to enabled. Now we've changed the strategy and reset the default value to auto. So the hackernews telemetry test no longer needs to be disabled. BUG=665007 ==========
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Re-enable hackernews telemetry test on linux. Previously, we disabled the hackernews telemetry test as we tried to set the default value of touch-events flag to enabled. Now we've changed the strategy and reset the default value to auto. So the hackernews telemetry test no longer needs to be disabled. BUG=665007 ========== to ========== Re-enable hackernews telemetry test on linux. Previously, we disabled the hackernews telemetry test as we tried to set the default value of touch-events flag to enabled. Now we've changed the strategy and reset the default value to auto. And recently, we also passed the test with the flag set to be enabled. So the hackernews telemetry test no longer needs to be disabled. BUG=665007 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sunyunjia@chromium.org changed reviewers: + mustaq@chromium.org, nednguyen@chromium.org, nednguyen@google.com
PTAL, thanks!
Thanks a lot for doing the extra work to reenable test! lgtm
The CQ bit was checked by sunyunjia@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1484231621287230, "parent_rev": "9fb7181fd5cf504dc37aae3775c73c81e2fd4336", "commit_rev": "20b0d38e48ac6294d88377f1b09fbd54eb7704f4"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable hackernews telemetry test on linux. Previously, we disabled the hackernews telemetry test as we tried to set the default value of touch-events flag to enabled. Now we've changed the strategy and reset the default value to auto. And recently, we also passed the test with the flag set to be enabled. So the hackernews telemetry test no longer needs to be disabled. BUG=665007 ========== to ========== Re-enable hackernews telemetry test on linux. Previously, we disabled the hackernews telemetry test as we tried to set the default value of touch-events flag to enabled. Now we've changed the strategy and reset the default value to auto. And recently, we also passed the test with the flag set to be enabled. So the hackernews telemetry test no longer needs to be disabled. BUG=665007 Review-Url: https://codereview.chromium.org/2627163003 Cr-Commit-Position: refs/heads/master@{#443227} Committed: https://chromium.googlesource.com/chromium/src/+/20b0d38e48ac6294d88377f1b09f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/20b0d38e48ac6294d88377f1b09f... |