Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2627153006:
[ash-md] Uses a solid color layer for overview mode shield (Closed)
Description[ash-md] Uses a solid color layer for overview mode shield
Replaces a tdefault textured layer used for a shield with a solid color
layer.
BUG=537050, 624608
TEST=NONE - no visible change
Review-Url: https://codereview.chromium.org/2627153006
Cr-Commit-Position: refs/heads/master@{#443342}
Committed: https://chromium.googlesource.com/chromium/src/+/9f64e116d5324233335d9c76b83aee3d58790fc0
Patch Set 1 : [ash-md] Uses a solid color layer for overview mode shield #
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
varkha@chromium.org changed reviewers: + tdanderson@chromium.org
tdanderson@, can you please take a look? Something suggested by reveman@. Thanks!
Patchset #1 (id:1) has been deleted
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
reveman@chromium.org changed reviewers: + reveman@chromium.org
Is the shield widget only used to dim the background? In that case it would be much more efficient to do that when drawing the wallpaper as it would remove a huge amount of overdraw. This is still a step in the right direction so lgtm.
On 2017/01/12 19:25:30, reveman wrote: > Is the shield widget only used to dim the background? In that case it would be > much more efficient to do that when drawing the wallpaper as it would remove a > huge amount of overdraw. This is still a step in the right direction so lgtm. lgtm
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/12 19:25:30, reveman wrote: > Is the shield widget only used to dim the background? In that case it would be > much more efficient to do that when drawing the wallpaper as it would remove a > huge amount of overdraw. This is still a step in the right direction so lgtm. Yes, it is only dimming the wallpaper (and animating opacity).
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484252506335220,
"parent_rev": "a6b30160a85adeaa983877116a089ed46fa4bd62", "commit_rev":
"9f64e116d5324233335d9c76b83aee3d58790fc0"}
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Uses a solid color layer for overview mode shield Replaces a tdefault textured layer used for a shield with a solid color layer. BUG=537050 TEST=NONE - no visible change ========== to ========== [ash-md] Uses a solid color layer for overview mode shield Replaces a tdefault textured layer used for a shield with a solid color layer. BUG=537050 TEST=NONE - no visible change Review-Url: https://codereview.chromium.org/2627153006 Cr-Commit-Position: refs/heads/master@{#443342} Committed: https://chromium.googlesource.com/chromium/src/+/9f64e116d5324233335d9c76b83a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9f64e116d5324233335d9c76b83a...
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Uses a solid color layer for overview mode shield Replaces a tdefault textured layer used for a shield with a solid color layer. BUG=537050 TEST=NONE - no visible change Review-Url: https://codereview.chromium.org/2627153006 Cr-Commit-Position: refs/heads/master@{#443342} Committed: https://chromium.googlesource.com/chromium/src/+/9f64e116d5324233335d9c76b83a... ========== to ========== [ash-md] Uses a solid color layer for overview mode shield Replaces a tdefault textured layer used for a shield with a solid color layer. BUG=537050, 624608 TEST=NONE - no visible change Review-Url: https://codereview.chromium.org/2627153006 Cr-Commit-Position: refs/heads/master@{#443342} Committed: https://chromium.googlesource.com/chromium/src/+/9f64e116d5324233335d9c76b83a... ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
