Gtk3: Fix separator color on Gtk3.20

Gtk3: Fix separator color on Gtk3.20

Gtk3.20 changed the selector for menu separators.  This CL adds a
version check to use the appropriate selector.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2627153003
Cr-Commit-Position: refs/heads/master@{#443478}
Committed: https://chromium.googlesource.com/chromium/src/+/37b2a2a8be9512011adbe0667299ba2436039a13

[Elliot Glaysher, 2017-01-12 18:15:43]

https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/native_theme_gtk3.cc (right):

https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/native_theme_gtk3.cc:146: (gtk_get_major_version() ==
3 && gtk_get_minor_version() >= 20)) {
Separate this blob of version checks into its own function now? I've seen this
exact thing several times.

[Tom (Use chromium acct), 2017-01-12 22:12:04]

https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/native_theme_gtk3.cc (right):

https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/native_theme_gtk3.cc:146: (gtk_get_major_version() ==
3 && gtk_get_minor_version() >= 20)) {
On 2017/01/12 18:15:43, Elliot Glaysher wrote:
> Separate this blob of version checks into its own function now? I've seen this
> exact thing several times.

Done.  Added GtkVersionCheck.  I made it generic because it felt weird having
IsGtkVersion3_20

[Elliot Glaysher, 2017-01-12 22:28:05]

lgtm

[Tom (Use chromium acct), 2017-01-12 22:48:40]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-01-12 22:49:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:51:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484261320613470,
"parent_rev": "b710b9ba8df2a9b9d89bd338c487ed1eaa0d4a20", "commit_rev":
"2b47b314a33c794e264b3c475ae392041f197d8e"}

[commit-bot: I haz the power, 2017-01-13 00:55:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484261320613470,
"parent_rev": "b710b9ba8df2a9b9d89bd338c487ed1eaa0d4a20", "commit_rev":
"2b47b314a33c794e264b3c475ae392041f197d8e"}

[commit-bot: I haz the power, 2017-01-13 00:58:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484261320613470,
"parent_rev": "b710b9ba8df2a9b9d89bd338c487ed1eaa0d4a20", "commit_rev":
"2b47b314a33c794e264b3c475ae392041f197d8e"}

[commit-bot: I haz the power, 2017-01-13 01:01:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:01:25]

Failed to commit the patch.

[Tom (Use chromium acct), 2017-01-13 02:27:25]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-01-13 02:28:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 03:47:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484274445418440,
"parent_rev": "7363faa38e61d285d3ebfb00880449aa741cfe9c", "commit_rev":
"37b2a2a8be9512011adbe0667299ba2436039a13"}

[commit-bot: I haz the power, 2017-01-13 03:47:47]

Description was changed from

==========
Gtk3: Fix separator color on Gtk3.20

Gtk3.20 changed the selector for menu separators.  This CL adds a
version check to use the appropriate selector.

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Fix separator color on Gtk3.20

Gtk3.20 changed the selector for menu separators.  This CL adds a
version check to use the appropriate selector.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2627153003
Cr-Commit-Position: refs/heads/master@{#443478}
Committed:
https://chromium.googlesource.com/chromium/src/+/37b2a2a8be9512011adbe0667299...
==========

[commit-bot: I haz the power, 2017-01-13 03:47:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37b2a2a8be9512011adbe0667299...