Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2627153003: Gtk3: Fix separator color on Gtk3.20 (Closed)

Created:
3 years, 11 months ago by Tom (Use chromium acct)
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix separator color on Gtk3.20 Gtk3.20 changed the selector for menu separators. This CL adds a version check to use the appropriate selector. BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2627153003 Cr-Commit-Position: refs/heads/master@{#443478} Committed: https://chromium.googlesource.com/chromium/src/+/37b2a2a8be9512011adbe0667299ba2436039a13

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add GtkVersionCheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 1 2 chunks +21 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Tom (Use chromium acct)
3 years, 11 months ago (2017-01-12 02:37:27 UTC) #1
Elliot Glaysher
https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/native_theme_gtk3.cc File chrome/browser/ui/libgtkui/native_theme_gtk3.cc (right): https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/native_theme_gtk3.cc#newcode146 chrome/browser/ui/libgtkui/native_theme_gtk3.cc:146: (gtk_get_major_version() == 3 && gtk_get_minor_version() >= 20)) { Separate ...
3 years, 11 months ago (2017-01-12 18:15:43 UTC) #2
Tom (Use chromium acct)
https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/native_theme_gtk3.cc File chrome/browser/ui/libgtkui/native_theme_gtk3.cc (right): https://codereview.chromium.org/2627153003/diff/1/chrome/browser/ui/libgtkui/native_theme_gtk3.cc#newcode146 chrome/browser/ui/libgtkui/native_theme_gtk3.cc:146: (gtk_get_major_version() == 3 && gtk_get_minor_version() >= 20)) { On ...
3 years, 11 months ago (2017-01-12 22:12:04 UTC) #3
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-12 22:28:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627153003/20001
3 years, 11 months ago (2017-01-12 22:49:40 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
3 years, 11 months ago (2017-01-13 01:01:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627153003/20001
3 years, 11 months ago (2017-01-13 02:28:05 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 03:47:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37b2a2a8be9512011adbe0667299...

Powered by Google App Engine
This is Rietveld 408576698