Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2627143003: Remove message about TLS renegotiation info extension. (Closed)

Created:
3 years, 11 months ago by davidben
Modified:
3 years, 11 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, markusheintz_, msramek+watch_chromium.org, pkl (ping after 24h if needed), raymes+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove message about TLS renegotiation info extension. In Chrome for Android, but not other ports, servers which don't support the renegotiation info extension have a "The server does not support the TLS renegotiation extension" note in the connection UI. We don't show this on other platforms and have no plans to mandate the extension (not worth spending the breakage budget on this), so remove it. BUG=680281 Review-Url: https://codereview.chromium.org/2627143003 Cr-Commit-Position: refs/heads/master@{#444081} Committed: https://chromium.googlesource.com/chromium/src/+/9ea5bc07bb60e1247b59b4942366d147c0a081d0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -33 lines) Patch
M chrome/browser/ui/website_settings/website_settings.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M components/pageinfo_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/page_info_model.cc View 2 chunks +0 lines, -9 lines 1 comment Download
M net/socket/ssl_client_socket_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket/ssl_server_socket_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/ssl/ssl_connection_status_flags.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
davidben
svaldez for primary review estark for chrome/browser/ui/website_settings rohitrao for ios/chrome/browser/ui/omnibox jochen for components https://codereview.chromium.org/2627143003/diff/1/ios/chrome/browser/ui/omnibox/page_info_model.cc File ...
3 years, 11 months ago (2017-01-11 23:56:24 UTC) #4
estark
c/b/ui/website_settings lgtm
3 years, 11 months ago (2017-01-12 02:19:28 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 08:37:26 UTC) #8
svaldez
lgtm, +12.
3 years, 11 months ago (2017-01-12 15:40:18 UTC) #9
rohitrao (ping after 24h)
ios lGTM
3 years, 11 months ago (2017-01-16 12:58:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627143003/1
3 years, 11 months ago (2017-01-17 16:37:48 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 17:34:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ea5bc07bb60e1247b59b4942366...

Powered by Google App Engine
This is Rietveld 408576698