Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2627113005: Factor PropertyTreeManager out of PaintArtifactCompositor. (Closed)

Created:
3 years, 11 months ago by wkorman
Modified:
3 years, 11 months ago
Reviewers:
ajuma, pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor PropertyTreeManager out of PaintArtifactCompositor. BUG=674258 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2627113005 Cr-Commit-Position: refs/heads/master@{#444150} Committed: https://chromium.googlesource.com/chromium/src/+/9bf3bd10297e90363f9d68ba23569ba4e2fe57da

Patch Set 1 #

Patch Set 2 : Sync to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -481 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 6 chunks +7 lines, -481 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.h View 1 chunk +125 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp View 1 chunk +424 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
wkorman
Exploring per my comment in http://crrev.com/2626353002. IMO this improves maintainability and allows for more easily ...
3 years, 11 months ago (2017-01-13 00:44:10 UTC) #3
ajuma
lgtm, I think this makes the code easier to understand/maintain. IMO relying on documentation/review to ...
3 years, 11 months ago (2017-01-13 01:09:12 UTC) #4
pdr.
On 2017/01/13 at 01:09:12, ajuma wrote: > lgtm, I think this makes the code easier ...
3 years, 11 months ago (2017-01-13 05:02:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627113005/20001
3 years, 11 months ago (2017-01-17 19:49:00 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:29:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9bf3bd10297e90363f9d68ba2356...

Powered by Google App Engine
This is Rietveld 408576698