Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2627103004: DevTools: make cpu throttling manager a control factory we can reuse. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
caseq, dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: make cpu throttling manager a control factory we can reuse. Review-Url: https://codereview.chromium.org/2627103004 Cr-Commit-Position: refs/heads/master@{#443381} Committed: https://chromium.googlesource.com/chromium/src/+/25b12b9767399f5a29cb74e20cc9e7fa64cc532c

Patch Set 1 #

Total comments: 4

Patch Set 2 : for landing #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -85 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js View 1 1 chunk +88 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 5 chunks +4 lines, -85 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
pfeldman
3 years, 11 months ago (2017-01-12 02:29:37 UTC) #2
caseq
lgtm https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js File third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js (right): https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js#newcode7 third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js:7: * @unrestricted nit: can you remove it? https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js#newcode40 ...
3 years, 11 months ago (2017-01-12 02:59:12 UTC) #3
pfeldman
All done.
3 years, 11 months ago (2017-01-12 18:34:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627103004/20001
3 years, 11 months ago (2017-01-12 18:35:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/25b12b9767399f5a29cb74e20cc9e7fa64cc532c
3 years, 11 months ago (2017-01-12 22:09:44 UTC) #10
dgozman
https://codereview.chromium.org/2627103004/diff/20001/third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js File third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js (right): https://codereview.chromium.org/2627103004/diff/20001/third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js#newcode46 third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js:46: targetAdded(target) { This goes against our common scheme, which ...
3 years, 11 months ago (2017-01-13 03:03:18 UTC) #12
pfeldman
> This goes against our common scheme Not against, but cuts some corners, true. >, ...
3 years, 11 months ago (2017-01-13 04:19:45 UTC) #13
dgozman
3 years, 11 months ago (2017-01-13 15:58:01 UTC) #14
Message was sent while issue was closed.
On 2017/01/13 04:19:45, pfeldman wrote:
> > This goes against our common scheme
> 
> Not against, but cuts some corners, true.
> 
> >, which would be:
> > - CPUThrottlingModel talking to agents, having rate(), setRate() and
> RateChanged
> 
> Which model do we use for emulation agent these days?
> 
> > - CPUThrottlingSelector which listens to the model and calls methods on it.

DeviceModeModel

Powered by Google App Engine
This is Rietveld 408576698