DevTools: make cpu throttling manager a control factory we can reuse.

DevTools: make cpu throttling manager a control factory we can reuse.

Review-Url: https://codereview.chromium.org/2627103004
Cr-Commit-Position: refs/heads/master@{#443381}
Committed: https://chromium.googlesource.com/chromium/src/+/25b12b9767399f5a29cb74e20cc9e7fa64cc532c

[pfeldman, 2017-01-12 02:29:36]

pfeldman@chromium.org changed reviewers:
+ alph@chromium.org, caseq@chromium.org

[caseq, 2017-01-12 02:59:12]

lgtm

https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js
(right):

https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js:7:
* @unrestricted
nit: can you remove it?

https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js:40:
return this._throttlingRate || 1;
nit: "|| 1" is hopefully redundant.

https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js:81:
disposeControl(control) {
unused?

https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2627103004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:135:
this._cpuThrottlingCombobox = this._cpuThrottlingManager.createControl();
nit: make it local

[pfeldman, 2017-01-12 18:34:46]

All done.

[pfeldman, 2017-01-12 18:35:11]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-01-12 18:35:12]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2627103004/#ps20001
(title: "for landing")

[commit-bot: I haz the power, 2017-01-12 18:35:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:09:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484246111921320,
"parent_rev": "1a17a732d52a25fc250243aa4b968de6b3d50739", "commit_rev":
"25b12b9767399f5a29cb74e20cc9e7fa64cc532c"}

[commit-bot: I haz the power, 2017-01-12 22:09:44]

Description was changed from

==========
DevTools: make cpu throttling manager a control factory we can reuse.
==========

to

==========
DevTools: make cpu throttling manager a control factory we can reuse.

Review-Url: https://codereview.chromium.org/2627103004
Cr-Commit-Position: refs/heads/master@{#443381}
Committed:
https://chromium.googlesource.com/chromium/src/+/25b12b9767399f5a29cb74e20cc9...
==========

[commit-bot: I haz the power, 2017-01-12 22:09:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25b12b9767399f5a29cb74e20cc9...

[dgozman, 2017-01-13 03:03:17]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-01-13 03:03:18]

https://codereview.chromium.org/2627103004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js
(right):

https://codereview.chromium.org/2627103004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js:46:
targetAdded(target) {
This goes against our common scheme, which would be:
- CPUThrottlingModel talking to agents, having rate(), setRate() and RateChanged
event.
- CPUThrottlingSelector which listens to the model and calls methods on it.

[pfeldman, 2017-01-13 04:19:45]

> This goes against our common scheme

Not against, but cuts some corners, true.

>, which would be:
> - CPUThrottlingModel talking to agents, having rate(), setRate() and
RateChanged

Which model do we use for emulation agent these days?

> - CPUThrottlingSelector which listens to the model and calls methods on it.

[dgozman, 2017-01-13 15:58:01]

On 2017/01/13 04:19:45, pfeldman wrote:
> > This goes against our common scheme
> 
> Not against, but cuts some corners, true.
> 
> >, which would be:
> > - CPUThrottlingModel talking to agents, having rate(), setRate() and
> RateChanged
> 
> Which model do we use for emulation agent these days?
> 
> > - CPUThrottlingSelector which listens to the model and calls methods on it.

DeviceModeModel