Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2627093002: arc: Enable silent auth flow by default. (Closed)

Created:
3 years, 11 months ago by khmel
Modified:
3 years, 11 months ago
Reviewers:
elijahtaylor1
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Enable silent auth flow by default. BUG=b/34219301 BUG=680166 TEST=Manually Review-Url: https://codereview.chromium.org/2627093002 Cr-Commit-Position: refs/heads/master@{#444769} Committed: https://chromium.googlesource.com/chromium/src/+/e17519010f463724f7c81bc9b470ba142c9ec3a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/arc/arc_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
khmel
Hi Elijah, PTAL, This will enable silent flow for M56 beta once merged in next ...
3 years, 11 months ago (2017-01-11 17:34:33 UTC) #1
khmel
Actually forgot to add reviewer :)
3 years, 11 months ago (2017-01-11 17:36:16 UTC) #3
elijahtaylor1
lgtm, would like to have some approval in https://bugs.chromium.org/p/chromium/issues/detail?id=682377 before submitting
3 years, 11 months ago (2017-01-18 20:39:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627093002/1
3 years, 11 months ago (2017-01-19 16:26:31 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 17:08:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e17519010f463724f7c81bc9b470...

Powered by Google App Engine
This is Rietveld 408576698