WebUI: Remove i18n from cr_elements/network

WebUI: Remove i18n from cr_elements/network

This includes changes in cr_onc_types.js to allow enums to be
used as @param types.

BUG=670767
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627023006
Cr-Commit-Position: refs/heads/master@{#444772}
Committed: https://chromium.googlesource.com/chromium/src/+/693b38c3882550aabf0ad1d706635e3c7810d855

[stevenjb, 2017-01-13 17:47:48]

Description was changed from

==========
WebUI: Remove i18n from cr_elements/network

This includes changes in cr_onc_types.js to allow enums to be
used as @param types.

BUG=670767
==========

to

==========
WebUI: Remove i18n from cr_elements/network

This includes changes in cr_onc_types.js to allow enums to be
used as @param types.

BUG=670767
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-13 20:31:26]

stevenjb@chromium.org changed reviewers:
+ alemate@chromium.org, dbeam@chromium.org

[Alexander Alekseev, 2017-01-13 22:48:57]

lgtm

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:136: },
That's sad that these strings have to be initialized in different places
(oobe_welcome.js, settings_ui.js).
Is there a way to check that all the strings used are initialized?

[stevenjb, 2017-01-14 06:11:41]

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:136: },
On 2017/01/13 22:48:57, Alexander Alekseev wrote:
> That's sad that these strings have to be initialized in different places
> (oobe_welcome.js, settings_ui.js).
> Is there a way to check that all the strings used are initialized?

Well, we could load a shared JS file, but I'm not sure that's really any better.

I've audited the code, and the closure compiler will complain if we try to
directly access a property that isn't defined in CrOncStrings. Other than that,
an error will be thrown if the property doesn't exist, which is really about all
that we can do.

[stevenjb, 2017-01-17 20:34:47]

dbeam@ - ping

[Dan Beam, 2017-01-18 02:00:23]

lgtm

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:135:
loadTimeData.getString('proxySettingsMenuName');
why are you doing this separately from the CrOncStrings = {...} block?

[stevenjb, 2017-01-18 19:49:24]

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2627023006/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:135:
loadTimeData.getString('proxySettingsMenuName');
On 2017/01/18 02:00:23, Dan Beam (slow - converging) wrote:
> why are you doing this separately from the CrOncStrings = {...} block?

I thought closure would complain since these are not declared members, but it
doesn't, so changed.

[stevenjb, 2017-01-18 19:49:58]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-01-18 19:49:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
alemate@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2627023006/#ps60001
(title: "Add custom items in struct")

[commit-bot: I haz the power, 2017-01-18 19:50:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:06:54]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[stevenjb, 2017-01-19 16:41:34]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-01-19 16:41:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
alemate@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2627023006/#ps100001
(title: "Allow <if> in settings_ui.html")

[commit-bot: I haz the power, 2017-01-19 16:41:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:36:47]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484844094261190,
"parent_rev": "2ff3fe13ff8f01226d36f63e9e695bbaf747dbdb", "commit_rev":
"693b38c3882550aabf0ad1d706635e3c7810d855"}

[commit-bot: I haz the power, 2017-01-19 17:37:26]

Description was changed from

==========
WebUI: Remove i18n from cr_elements/network

This includes changes in cr_onc_types.js to allow enums to be
used as @param types.

BUG=670767
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Remove i18n from cr_elements/network

This includes changes in cr_onc_types.js to allow enums to be
used as @param types.

BUG=670767
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627023006
Cr-Commit-Position: refs/heads/master@{#444772}
Committed:
https://chromium.googlesource.com/chromium/src/+/693b38c3882550aabf0ad1d70663...
==========

[commit-bot: I haz the power, 2017-01-19 17:37:27]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/693b38c3882550aabf0ad1d70663...