Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2627023004: Migrate WTF::Vector::append() to ::push_back() in XPathGrammar (Closed)

Created:
3 years, 11 months ago by pilgrim_google
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, dominicc+watchlist_chromium.org, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() in XPathGrammar As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL changes the template file that is used to generate XPathGrammar.cpp. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2627023004 Cr-Commit-Position: refs/heads/master@{#443452} Committed: https://chromium.googlesource.com/chromium/src/+/8702f9b3c88ac69fa7190e87bdb2d4fcdba594db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/xml/XPathGrammar.y View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 11 months ago (2017-01-12 21:06:06 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-12 23:52:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627023004/1
3 years, 11 months ago (2017-01-13 00:52:27 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:51:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8702f9b3c88ac69fa7190e87bdb2...

Powered by Google App Engine
This is Rietveld 408576698