Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2627023003: Add presubmit check for Google support URL format. (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add presubmit check for Google support URL format. See bug for details. tl;dr: we should not use direct links like support.google.com/chrome/answer/123456 For now this is an ignoreable upload-only prompt. BUG=679462 Review-Url: https://codereview.chromium.org/2627023003 Cr-Commit-Position: refs/heads/master@{#443255} Committed: https://chromium.googlesource.com/chromium/src/+/e17314a0eeb014ead59c49754ee6bb2e301dfb2b

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 chunks +16 lines, -0 lines 0 comments Download
M PRESUBMIT_test.py View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Evan Stade
3 years, 11 months ago (2017-01-12 02:19:24 UTC) #3
Paweł Hajdan Jr.
LGTM Are there any docs how to transform /answer to p= ?
3 years, 11 months ago (2017-01-12 07:49:13 UTC) #5
Evan Stade
On 2017/01/12 07:49:13, Paweł Hajdan Jr. wrote: > LGTM > > Are there any docs ...
3 years, 11 months ago (2017-01-12 16:09:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627023003/20001
3 years, 11 months ago (2017-01-12 16:10:07 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 16:22:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e17314a0eeb014ead59c49754ee6...

Powered by Google App Engine
This is Rietveld 408576698