Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2627003007: Add TEAM/COMPONENT information (Closed)

Created:
3 years, 11 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, stgao, anantha, sshruthi1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add TEAM/COMPONENT information BUG=679905 Please help us to verify the TEAM/COMPONENT information. If the current information is incorrect, please suggest the correct team or component or None(if not applicable). Review-Url: https://codereview.chromium.org/2627003007 Cr-Commit-Position: refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ad51088c0e8776e8dcd963dbe752c4035ba6dab6

Patch Set 1 #

Total comments: 30

Patch Set 2 : update team compo #

Total comments: 12

Patch Set 3 : update wrong team #

Total comments: 2

Patch Set 4 : Merge branch 'master' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M base/allocator/partition_allocator/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/memory/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/memory/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/OWNERS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/jinja2/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/markupsafe/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/idl_parser/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (9 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 11 months ago (2017-01-12 23:38:29 UTC) #2
haraken
On 2017/01/12 23:38:29, ymzhang1 wrote: > Hello, > > We are adding COMPONENT/TEAM information into ...
3 years, 11 months ago (2017-01-13 02:02:47 UTC) #4
ymzhang1
On 2017/01/13 02:02:47, haraken wrote: > On 2017/01/12 23:38:29, ymzhang1 wrote: > > Hello, > ...
3 years, 11 months ago (2017-01-13 19:31:06 UTC) #5
haraken
https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS File base/allocator/partition_allocator/OWNERS (right): https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS#newcode4 base/allocator/partition_allocator/OWNERS:4: # TEAM: oilpan-reviews@chromium.org platform-architecture-dev@chromium.org https://codereview.chromium.org/2627003007/diff/1/content/browser/memory/OWNERS File content/browser/memory/OWNERS (right): https://codereview.chromium.org/2627003007/diff/1/content/browser/memory/OWNERS#newcode5 ...
3 years, 11 months ago (2017-01-16 01:41:50 UTC) #6
ymzhang1
https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS File base/allocator/partition_allocator/OWNERS (right): https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS#newcode4 base/allocator/partition_allocator/OWNERS:4: # TEAM: oilpan-reviews@chromium.org On 2017/01/16 01:41:49, haraken wrote: > ...
3 years, 11 months ago (2017-01-17 18:45:27 UTC) #7
haraken
On 2017/01/17 18:45:27, ymzhang1 wrote: > https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS > File base/allocator/partition_allocator/OWNERS (right): > > https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS#newcode4 > ...
3 years, 11 months ago (2017-01-18 00:13:06 UTC) #8
ymzhang1
https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS File base/allocator/partition_allocator/OWNERS (right): https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS#newcode4 base/allocator/partition_allocator/OWNERS:4: # TEAM: oilpan-reviews@chromium.org On 2017/01/16 01:41:49, haraken wrote: > ...
3 years, 11 months ago (2017-01-18 18:05:15 UTC) #10
haraken
On 2017/01/18 18:05:15, ymzhang1 wrote: > https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS > File base/allocator/partition_allocator/OWNERS (right): > > https://codereview.chromium.org/2627003007/diff/1/base/allocator/partition_allocator/OWNERS#newcode4 > ...
3 years, 11 months ago (2017-01-18 23:56:45 UTC) #11
ymzhang1
Here is the updated CL. +tkent regarding team/component in third_party/WebKit/public/OWNERS.
3 years, 11 months ago (2017-01-19 00:26:39 UTC) #13
tkent
> +tkent > regarding team/component in third_party/WebKit/public/OWNERS. It looks ok.
3 years, 11 months ago (2017-01-19 01:31:55 UTC) #14
haraken
https://codereview.chromium.org/2627003007/diff/20001/third_party/WebKit/Source/bindings/OWNERS File third_party/WebKit/Source/bindings/OWNERS (right): https://codereview.chromium.org/2627003007/diff/20001/third_party/WebKit/Source/bindings/OWNERS#newcode14 third_party/WebKit/Source/bindings/OWNERS:14: # TEAM: platform-architecture-dev@chromium.org blink-reviews-bindings@ https://codereview.chromium.org/2627003007/diff/20001/third_party/WebKit/Source/modules/OWNERS File third_party/WebKit/Source/modules/OWNERS (right): https://codereview.chromium.org/2627003007/diff/20001/third_party/WebKit/Source/modules/OWNERS#newcode12 ...
3 years, 11 months ago (2017-01-19 02:05:35 UTC) #15
ymzhang1
https://codereview.chromium.org/2627003007/diff/20001/third_party/WebKit/Source/bindings/OWNERS File third_party/WebKit/Source/bindings/OWNERS (right): https://codereview.chromium.org/2627003007/diff/20001/third_party/WebKit/Source/bindings/OWNERS#newcode14 third_party/WebKit/Source/bindings/OWNERS:14: # TEAM: platform-architecture-dev@chromium.org On 2017/01/19 02:05:35, haraken wrote: > ...
3 years, 11 months ago (2017-01-19 22:31:19 UTC) #16
haraken
LGTM https://codereview.chromium.org/2627003007/diff/40001/tools/directory_ownership/log.json File tools/directory_ownership/log.json (right): https://codereview.chromium.org/2627003007/diff/40001/tools/directory_ownership/log.json#newcode8 tools/directory_ownership/log.json:8: } What is this file?
3 years, 11 months ago (2017-01-20 00:17:35 UTC) #17
ymzhang1
https://codereview.chromium.org/2627003007/diff/40001/tools/directory_ownership/log.json File tools/directory_ownership/log.json (right): https://codereview.chromium.org/2627003007/diff/40001/tools/directory_ownership/log.json#newcode8 tools/directory_ownership/log.json:8: } On 2017/01/20 00:17:35, haraken wrote: > > What ...
3 years, 11 months ago (2017-01-20 00:45:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627003007/60001
3 years, 11 months ago (2017-01-20 00:46:36 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ad51088c0e8776e8dcd963dbe752c4035ba6dab6
3 years, 11 months ago (2017-01-20 01:58:09 UTC) #24
Wez
Hallo asvitkine@chromium.org! Due to a depot_tools patch which mistakenly removed the OWNERS check for non-source ...
3 years, 10 months ago (2017-02-07 22:34:21 UTC) #26
Alexei Svitkine (slow)
3 years, 10 months ago (2017-02-07 22:42:04 UTC) #27
Message was sent while issue was closed.
tools/metrics/histograms/OWNERS lgtm

Powered by Google App Engine
This is Rietveld 408576698