Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2626993003: MD Settings: add borders between toggle rows on basic/advanced pages (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add borders between toggle rows on basic/advanced pages R=dschuyler@chromium.org BUG=673953 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2626993003 Cr-Commit-Position: refs/heads/master@{#443492} Committed: https://chromium.googlesource.com/chromium/src/+/c43f4b93273c33a1a3c0ea483bca8559a8fd87e9

Patch Set 1 #

Total comments: 2

Patch Set 2 : axe flex-layout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -43 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 3 chunks +55 lines, -39 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.html View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Dan Beam
3 years, 11 months ago (2017-01-12 03:47:23 UTC) #3
dschuyler
lgtm https://codereview.chromium.org/2626993003/diff/1/chrome/browser/resources/settings/system_page/system_page.html File chrome/browser/resources/settings/system_page/system_page.html (right): https://codereview.chromium.org/2626993003/diff/1/chrome/browser/resources/settings/system_page/system_page.html#newcode24 chrome/browser/resources/settings/system_page/system_page.html:24: <settings-toggle-button class="flex" id="hardwareAcceleration" Since this is now in ...
3 years, 11 months ago (2017-01-13 01:48:16 UTC) #7
Dan Beam
https://codereview.chromium.org/2626993003/diff/1/chrome/browser/resources/settings/system_page/system_page.html File chrome/browser/resources/settings/system_page/system_page.html (right): https://codereview.chromium.org/2626993003/diff/1/chrome/browser/resources/settings/system_page/system_page.html#newcode24 chrome/browser/resources/settings/system_page/system_page.html:24: <settings-toggle-button class="flex" id="hardwareAcceleration" On 2017/01/13 01:48:15, dschuyler wrote: > ...
3 years, 11 months ago (2017-01-13 03:35:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626993003/20001
3 years, 11 months ago (2017-01-13 03:36:47 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 04:48:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c43f4b93273c33a1a3c0ea483bca...

Powered by Google App Engine
This is Rietveld 408576698