Reland "Fix RGBA alpha parsing and serialization to adhere to W3 standard."

Reland "Fix RGBA alpha parsing and serialization to adhere to W3 standard."
Using NeedsManualRebaseline since automatically rebaseline does not work

Original description:
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414
Review-Url: https://codereview.chromium.org/2626973005
Cr-Commit-Position: refs/heads/master@{#445802}
Committed: https://chromium.googlesource.com/chromium/src/+/fdab33b3484cd6e1259015d0387a122cc62bf73f

[ktyliu, 2017-01-12 21:54:13]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:55:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:17:04]

Dry run: This issue passed the CQ dry run.

[ktyliu, 2017-01-13 02:08:28]

ktyliu@chromium.org changed reviewers:
+ eae@chromium.org, sashab@chromium.org

[ktyliu, 2017-01-13 02:08:31]

Hi Sasha, Emil,

Sorry my last patch was reverted.

I've checked with author of rebaseline-cl, and he agrees that using
NeedsManualRebaseline for now is good until we figure out the root problem --
https://bugs.chromium.org/p/chromium/issues/detail?id=680768

Hope this is okay.

Thanks,
Kevin

[sashab, 2017-01-13 02:16:49]

Still LGTM, I don't have OWNERs on platform/ or web/ though so you'll need LGTM
for those

[ktyliu, 2017-01-16 22:11:00]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 22:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 00:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 00:02:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ktyliu, 2017-01-17 02:16:09]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 02:16:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 04:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 04:15:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-17 06:21:31]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 06:21:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 08:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 08:26:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ktyliu, 2017-01-18 00:48:43]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:49:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 01:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:07:35]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ktyliu, 2017-01-18 02:44:58]

Hi Emil,
 
Can you help RSLGTM for the platform/ change?

Thanks,
Kevin

[ktyliu, 2017-01-24 05:04:43]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 05:04:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 07:46:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 07:46:31]

Dry run: This issue passed the CQ dry run.

[eae, 2017-01-24 16:52:40]

LGTM, thanks for your patience!

[ktyliu, 2017-01-24 20:26:52]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-24 20:26:53]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2626973005/#ps100001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-01-24 20:27:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:55:32]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485289612501490,
"parent_rev": "c6ddb615e307d10bff949570707cbaa964f5795d", "commit_rev":
"fdab33b3484cd6e1259015d0387a122cc62bf73f"}

[commit-bot: I haz the power, 2017-01-24 20:56:11]

Description was changed from

==========
Reland "Fix RGBA alpha parsing and serialization to adhere to W3 standard."
Using NeedsManualRebaseline since automatically rebaseline does not work

Original description:
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414
==========

to

==========
Reland "Fix RGBA alpha parsing and serialization to adhere to W3 standard."
Using NeedsManualRebaseline since automatically rebaseline does not work

Original description:
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html and also that the
implementation is now same as Firefox as noted in the bug.

Note a large number of tests need to be fixed, many of them because:
- *-expected.txt specifically had bad alpha values such as 0.501961 or
- an alpha value of 0.5 was previously 127 but should have been 128.
The latter applies to the updated expected images too where the only
difference was tiny bit of alpha (and rgb when alpha blended) change.

BUG=453414

Review-Url: https://codereview.chromium.org/2626973005
Cr-Commit-Position: refs/heads/master@{#445802}
Committed:
https://chromium.googlesource.com/chromium/src/+/fdab33b3484cd6e1259015d0387a...
==========

[commit-bot: I haz the power, 2017-01-24 20:56:13]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fdab33b3484cd6e1259015d0387a...