components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h - Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy (Closed)

Patch Set: Addressed nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

index ee75daf341a6eb72ce08c7223bd9e9e099eb44e7..18374527716909eb5286db5d2fdd8a8f08adc847 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h

@@ -42,8 +42,6 @@ class DataReductionProxyMutableConfigValues

// Overrides of |DataReductionProxyConfigValues|

bool promo_allowed() const override;

bool holdback() const override;

- bool allowed() const override;

- bool fallback_allowed() const override;

const std::vector<DataReductionProxyServer> proxies_for_http() const override;

const GURL& secure_proxy_check_url() const override;

@@ -53,8 +51,6 @@ class DataReductionProxyMutableConfigValues

private:

bool promo_allowed_;

bool holdback_;

- bool allowed_;

- bool fallback_allowed_;

std::vector<DataReductionProxyServer> proxies_for_http_;

GURL secure_proxy_check_url_;