components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc - Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy (Closed)

Patch Set: Addressed nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

index 2aed7798c02f9639894825322a0ca9e621b10ac9..da8d668cad67d3f0e8633af484c844977fc3d8af 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

@@ -33,7 +33,7 @@ TEST(ChromeNetworkDailyDataSavingMetricsTest,

base::MessageLoopForIO message_loop;

std::unique_ptr<DataReductionProxyTestContext> test_context =

DataReductionProxyTestContext::Builder()

- .WithParamsFlags(DataReductionProxyParams::kAllowed)

+ .WithParamsFlags(0)

.WithParamsDefinitions(TestDataReductionProxyParams::HAS_ORIGIN)

.Build();

TestDataReductionProxyConfig* config = test_context->config();