Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2626963002: Roll WebGL 046d1f6..06ad9fd (Closed)

Created:
3 years, 11 months ago by yunchao
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Yang Gu, Jamie Madill
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL 046d1f6..06ad9fd https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f6..06ad9fd BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2626963002 Cr-Commit-Position: refs/heads/master@{#442962} Committed: https://chromium.googlesource.com/chromium/src/+/b9b03f98739ab86f5d2f4f608a9770e6049542ae

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -13 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 7 chunks +41 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 3 8 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 27 (21 generated)
yunchao
Ken and Zhenyao, PTAL. Finally, all bots are green.But this roll-in led to many failures, ...
3 years, 11 months ago (2017-01-11 15:47:43 UTC) #19
Zhenyao Mo
On 2017/01/11 15:47:43, yunchao wrote: > Ken and Zhenyao, PTAL. Finally, all bots are green.But ...
3 years, 11 months ago (2017-01-11 18:35:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626963002/60001
3 years, 11 months ago (2017-01-11 18:35:39 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b9b03f98739ab86f5d2f4f608a9770e6049542ae
3 years, 11 months ago (2017-01-11 18:43:16 UTC) #25
Ken Russell (switch to Gerrit)
Thanks Yunchao for handling this difficult roll. In the future, if you could update the ...
3 years, 11 months ago (2017-01-11 19:55:55 UTC) #26
yunchao
3 years, 11 months ago (2017-01-12 00:46:31 UTC) #27
Message was sent while issue was closed.
On 2017/01/11 19:55:55, Ken Russell wrote:
> Thanks Yunchao for handling this difficult roll.
> 
> In the future, if you could update the BUG= line to contain all the bug IDs
that
> were touched (removed / changed / added) in the test expectations, that would
be
> helpful for tracking purposes. Thanks.

Got it. Thanks for your reminder, Ken. This roll-in broke lots of tests. 
I was afraid you would receive lots of emails from every crbug updates
when this change is landed.

I will do this in future changes.

Powered by Google App Engine
This is Rietveld 408576698