|
|
DescriptionRoll WebGL 046d1f6..06ad9fd
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f6..06ad9fd
BUG=
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2626963002
Cr-Commit-Position: refs/heads/master@{#442962}
Committed: https://chromium.googlesource.com/chromium/src/+/b9b03f98739ab86f5d2f4f608a9770e6049542ae
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : fix #
Messages
Total messages: 27 (21 generated)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll WebGL 046d1f6..06ad9fd https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 046d1f6..06ad9fd https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org
Ken and Zhenyao, PTAL. Finally, all bots are green.But this roll-in led to many failures, I am afraid that the roll-in may break some FYI bots... Let's suppress the WebGL CTS expectation if so.
On 2017/01/11 15:47:43, yunchao wrote: > Ken and Zhenyao, PTAL. Finally, all bots are green.But this roll-in led to many > failures, I am afraid that the roll-in may break some FYI bots... Let's suppress > the WebGL CTS expectation if so. Thanks lgtm I'll keep an eye on FYI bots
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484159711025470, "parent_rev": "b907305177b8605893e4c6c0f46226ecaacd93be", "commit_rev": "b9b03f98739ab86f5d2f4f608a9770e6049542ae"}
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 046d1f6..06ad9fd https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 046d1f6..06ad9fd https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2626963002 Cr-Commit-Position: refs/heads/master@{#442962} Committed: https://chromium.googlesource.com/chromium/src/+/b9b03f98739ab86f5d2f4f608a97... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b9b03f98739ab86f5d2f4f608a97...
Message was sent while issue was closed.
Thanks Yunchao for handling this difficult roll. In the future, if you could update the BUG= line to contain all the bug IDs that were touched (removed / changed / added) in the test expectations, that would be helpful for tracking purposes. Thanks.
Message was sent while issue was closed.
On 2017/01/11 19:55:55, Ken Russell wrote: > Thanks Yunchao for handling this difficult roll. > > In the future, if you could update the BUG= line to contain all the bug IDs that > were touched (removed / changed / added) in the test expectations, that would be > helpful for tracking purposes. Thanks. Got it. Thanks for your reminder, Ken. This roll-in broke lots of tests. I was afraid you would receive lots of emails from every crbug updates when this change is landed. I will do this in future changes. |