Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2626943002: Add ServiceWorker.NavigationPreload.HeaderSize UMA (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
falken, rkaplow
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, asvitkine+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ServiceWorker.NavigationPreload.HeaderSize UMA BUG=649558 Review-Url: https://codereview.chromium.org/2626943002 Cr-Commit-Position: refs/heads/master@{#443086} Committed: https://chromium.googlesource.com/chromium/src/+/db73904ff35571b578ef8d05127ac0cf659037ca

Patch Set 1 #

Total comments: 2

Patch Set 2 : incorporated falken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
horo
PTAL
3 years, 11 months ago (2017-01-11 05:17:25 UTC) #2
falken
lgtm https://codereview.chromium.org/2626943002/diff/1/content/browser/service_worker/service_worker_fetch_dispatcher.cc File content/browser/service_worker/service_worker_fetch_dispatcher.cc (right): https://codereview.chromium.org/2626943002/diff/1/content/browser/service_worker/service_worker_fetch_dispatcher.cc#newcode451 content/browser/service_worker/service_worker_fetch_dispatcher.cc:451: version_->navigation_preload_state().header.length()); nit: seems better to put this below ...
3 years, 11 months ago (2017-01-11 05:28:05 UTC) #3
horo
Thank you. https://codereview.chromium.org/2626943002/diff/1/content/browser/service_worker/service_worker_fetch_dispatcher.cc File content/browser/service_worker/service_worker_fetch_dispatcher.cc (right): https://codereview.chromium.org/2626943002/diff/1/content/browser/service_worker/service_worker_fetch_dispatcher.cc#newcode451 content/browser/service_worker/service_worker_fetch_dispatcher.cc:451: version_->navigation_preload_state().header.length()); On 2017/01/11 05:28:05, falken wrote: > ...
3 years, 11 months ago (2017-01-11 06:13:07 UTC) #5
horo
rkaplow@ Could you please review histograms.xml?
3 years, 11 months ago (2017-01-11 06:13:58 UTC) #8
rkaplow
lgtm
3 years, 11 months ago (2017-01-11 15:57:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626943002/20001
3 years, 11 months ago (2017-01-12 00:00:46 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:40:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/db73904ff35571b578ef8d05127a...

Powered by Google App Engine
This is Rietveld 408576698