rewrite_to_chrome_style: Use constexpr as backdoor to get consistency

rewrite_to_chrome_style: Use constexpr as backdoor to get consistency

In the last cases of inconsistent evaluation of compile-time-constants
just make them constexpr and then ensure we always see constexpr things
as compile-time constants. Actually compiling figures this out even
though from the AST we see unresolved things that make this hard.

R=dcheng
BUG=677285
Review-Url: https://codereview.chromium.org/2626923004
Cr-Commit-Position: refs/heads/master@{#443115}
Committed: https://chromium.googlesource.com/chromium/src/+/362c69d27d39af6a9f6945099acb593cd6d96579

[danakj, 2017-01-11 20:54:27]

danakj@chromium.org changed reviewers:
+ pdr@chromium.org

[danakj, 2017-01-11 20:54:28]

Please have a look.

dcheng: clang
pdr: blink

[dcheng, 2017-01-11 21:07:40]

LGTM!

[pdr., 2017-01-11 21:10:21]

On 2017/01/11 at 20:54:28, danakj wrote:
> Please have a look.
> 
> dcheng: clang
> pdr: blink

LGTM

[danakj, 2017-01-11 21:16:03]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-01-11 21:16:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-11 23:42:28]

platform/heap/ LGTM

[commit-bot: I haz the power, 2017-01-12 01:40:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484169363840050, "parent_rev":
"21d2ea5e341bd8f4a51e73a858a2198bcd79f0b0", "commit_rev":
"362c69d27d39af6a9f6945099acb593cd6d96579"}

[commit-bot: I haz the power, 2017-01-12 01:40:49]

Description was changed from

==========
rewrite_to_chrome_style: Use constexpr as backdoor to get consistency

In the last cases of inconsistent evaluation of compile-time-constants
just make them constexpr and then ensure we always see constexpr things
as compile-time constants. Actually compiling figures this out even
though from the AST we see unresolved things that make this hard.

R=dcheng
BUG=677285
==========

to

==========
rewrite_to_chrome_style: Use constexpr as backdoor to get consistency

In the last cases of inconsistent evaluation of compile-time-constants
just make them constexpr and then ensure we always see constexpr things
as compile-time constants. Actually compiling figures this out even
though from the AST we see unresolved things that make this hard.

R=dcheng
BUG=677285

Review-Url: https://codereview.chromium.org/2626923004
Cr-Commit-Position: refs/heads/master@{#443115}
Committed:
https://chromium.googlesource.com/chromium/src/+/362c69d27d39af6a9f6945099acb...
==========

[commit-bot: I haz the power, 2017-01-12 01:40:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/362c69d27d39af6a9f6945099acb...