[Download Home] Add missing files to map

[Download Home] Add missing files to map                                         
                                                                                 
Problematically, new DownloadItems are created with no file name                 
when a download first starts.  This means that the                               
DownloadHistoryItemWrapper is added to the wrong part of the                     
FilePathsToDownloadItemsMap and can't be removed until the user                  
re-opens Download Home, which correctly records the DownloadItem                 
in the correct place.                                                            
                                                                                 
* Change the behavior so a download completion event also triggers               
  the item to be added to the map -- this time with the correct                  
  file path.                                                                     
                                                                                 
* Also make the FilePathsToDownloadItemsMap use a HashSet for its                
  secondary data structure.  It ends up slightly cleaner IMO.                    
                                                                                 
* Cleans up the StubbedProvider so that it can take in specific                  
  download percentages more easily.                                              
                                                                                 
* Add a new test for this behavior.                                              
                                                                                 
BUG=670583
TEST=DownloadHistoryAdapterTest*

Review-Url: https://codereview.chromium.org/2626903005
Cr-Commit-Position: refs/heads/master@{#442960}
Committed: https://chromium.googlesource.com/chromium/src/+/ff8ffc7fe93a0348148eea2221b093feb711da9a

[gone, 2017-01-11 03:22:24]

Description was changed from

==========
[Download Home] Add missing files to map

Problematically, new DownloadItems are created with no file name
when a download first starts.  This means that the
DownloadHistoryItemWrapper is added to the wrong part of the
FilePathsToDownloadItemsMap and can't be removed until the user
re-opens Download Home, which correctly records the DownloadItem
in the correct place.

Change the behavior so a download completion event also triggers
the item to be added to the map -- this time with the correct
file path.

Also make the FilePathsToDownloadItemsMap use a HashSet for its
secondary data structure.  It ends up slightly cleaner IMO.

BUG=670583
==========

to

==========
[Download Home] Add missing files to map                                        

                                                                                

Problematically, new DownloadItems are created with no file name                

when a download first starts.  This means that the                              

DownloadHistoryItemWrapper is added to the wrong part of the                    

FilePathsToDownloadItemsMap and can't be removed until the user                 

re-opens Download Home, which correctly records the DownloadItem                

in the correct place.                                                           

                                                                                

* Change the behavior so a download completion event also triggers              

  the item to be added to the map -- this time with the correct                 

  file path.                                                                    

                                                                                

* Also make the FilePathsToDownloadItemsMap use a HashSet for its               

  secondary data structure.  It ends up slightly cleaner IMO.                   

                                                                                

* Cleans up the StubbedProvider so that it can take in specific                 

  download percentages more easily.                                             

                                                                                

* Add a new test for this behavior.                                             

                                                                                

BUG=670583                                                                      

TEST=DownloadHistoryAdapterTest*
==========

[gone, 2017-01-11 03:27:33]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2017-01-11 03:28:26]

Er, not sure if I sent this just now or what, but PTAL.

[gone, 2017-01-11 03:30:47]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 03:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-01-11 16:57:23]

lgtm

[gone, 2017-01-11 17:52:52]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2017-01-11 17:53:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 18:40:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484157172145900,
"parent_rev": "228b81684d7f1d32f84b58abd7f50d5e1d9f439c", "commit_rev":
"ff8ffc7fe93a0348148eea2221b093feb711da9a"}

[commit-bot: I haz the power, 2017-01-11 18:40:37]

Description was changed from

==========
[Download Home] Add missing files to map                                        

                                                                                

Problematically, new DownloadItems are created with no file name                

when a download first starts.  This means that the                              

DownloadHistoryItemWrapper is added to the wrong part of the                    

FilePathsToDownloadItemsMap and can't be removed until the user                 

re-opens Download Home, which correctly records the DownloadItem                

in the correct place.                                                           

                                                                                

* Change the behavior so a download completion event also triggers              

  the item to be added to the map -- this time with the correct                 

  file path.                                                                    

                                                                                

* Also make the FilePathsToDownloadItemsMap use a HashSet for its               

  secondary data structure.  It ends up slightly cleaner IMO.                   

                                                                                

* Cleans up the StubbedProvider so that it can take in specific                 

  download percentages more easily.                                             

                                                                                

* Add a new test for this behavior.                                             

                                                                                

BUG=670583                                                                      

TEST=DownloadHistoryAdapterTest*
==========

to

==========
[Download Home] Add missing files to map                                        

                                                                                

Problematically, new DownloadItems are created with no file name                

when a download first starts.  This means that the                              

DownloadHistoryItemWrapper is added to the wrong part of the                    

FilePathsToDownloadItemsMap and can't be removed until the user                 

re-opens Download Home, which correctly records the DownloadItem                

in the correct place.                                                           

                                                                                

* Change the behavior so a download completion event also triggers              

  the item to be added to the map -- this time with the correct                 

  file path.                                                                    

                                                                                

* Also make the FilePathsToDownloadItemsMap use a HashSet for its               

  secondary data structure.  It ends up slightly cleaner IMO.                   

                                                                                

* Cleans up the StubbedProvider so that it can take in specific                 

  download percentages more easily.                                             

                                                                                

* Add a new test for this behavior.                                             

                                                                                

BUG=670583                                                                      

TEST=DownloadHistoryAdapterTest*

Review-Url: https://codereview.chromium.org/2626903005
Cr-Commit-Position: refs/heads/master@{#442960}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff8ffc7fe93a0348148eea2221b0...
==========

[commit-bot: I haz the power, 2017-01-11 18:40:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff8ffc7fe93a0348148eea2221b0...