Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2626863004: Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Yang, v8-mips-ports_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (patchset #7 id:120001 of https://codereview.chromium.org/2620753003/ ) Reason for revert: gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/8105 also on mac Original issue's description: > [TypeFeedbackVector] Root literal arrays in function literals slots > > Literal arrays and feedback vectors for a function can be garbage > collected if we don't have a rooted closure for the function, which > happens often. It's expensive to come back from this (recreating > boilerplates and gathering feedback again), and the cost is > disproportionate if the function was inlined into optimized code. > > To guard against losing these arrays when we need them, we'll now > create literal arrays when creating the feedback vector for the outer > closure, and root them strongly in that vector. > > BUG=v8:5456 > > Review-Url: https://codereview.chromium.org/2620753003 > Cr-Commit-Position: refs/heads/master@{#42258} > Committed: https://chromium.googlesource.com/v8/v8/+/31887804107bf5c103d915f5c601cfaaf1cd7cb6 TBR=bmeurer@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5456 Review-Url: https://codereview.chromium.org/2626863004 Cr-Commit-Position: refs/heads/master@{#42260} Committed: https://chromium.googlesource.com/v8/v8/+/3d9e2ea32d2cd09e5087cc507ee750fc2c18fbef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+533 lines, -329 lines) Patch
M src/builtins/arm/builtins-arm.cc View 5 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 5 chunks +14 lines, -8 lines 0 comments Download
M src/builtins/builtins-constructor.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M src/compiler.cc View 4 chunks +21 lines, -14 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/contexts.cc View 6 chunks +29 lines, -10 lines 0 comments Download
M src/debug/liveedit.cc View 5 chunks +33 lines, -77 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/objects.h View 7 chunks +21 lines, -6 lines 0 comments Download
M src/objects.cc View 8 chunks +69 lines, -54 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -14 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 3 chunks +208 lines, -3 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +1 line, -3 lines 0 comments Download
D test/mjsunit/strong-rooted-literals.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [TypeFeedbackVector] Root literal arrays in function literals slots
3 years, 11 months ago (2017-01-12 10:10:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626863004/1
3 years, 11 months ago (2017-01-12 10:10:46 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 10:11:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3d9e2ea32d2cd09e5087cc507ee750fc2c1...

Powered by Google App Engine
This is Rietveld 408576698