[wasm] (To|From)JSWrappers with I64 params throw a TypeError upon call.

[wasm] (To|From)JSWrappers with I64 params throw a TypeError upon call.

According to the latest spec changes the WasmToJS wrapper and the
JSToWasm wrapper through a TypeError if the signature of the wrapper
contains a I64 parameter or return value. Originally the TypeError was
thrown when the parameter or return value was converted to or from JS.

In addition I removed all special handling of I64 parameters and return
values in the wrappers which was already dead code.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2626853003
Cr-Commit-Position: refs/heads/master@{#42238}
Committed: https://chromium.googlesource.com/v8/v8/+/e904894915ff88c5f500fbc1bd816250885ae2d3

[ahaas, 2017-01-11 13:35:38]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 13:35:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-11 13:40:38]

lgtm with comment

https://codereview.chromium.org/2626853003/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2626853003/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2745: if (sig->GetReturn(i) == wasm::kWasmI64) {
Do you also want to check for S128 here? If so, maybe extract a helper function.

[commit-bot: I haz the power, 2017-01-11 14:02:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 14:02:22]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-01-11 14:04:34]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 14:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2017-01-11 14:04:45]

https://codereview.chromium.org/2626853003/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2626853003/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2745: if (sig->GetReturn(i) == wasm::kWasmI64) {
On 2017/01/11 at 13:40:37, titzer wrote:
> Do you also want to check for S128 here? If so, maybe extract a helper
function.

Done

[commit-bot: I haz the power, 2017-01-11 14:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 14:38:06]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-01-11 15:55:42]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2017-01-11 15:55:42]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2626853003/#ps20001
(title: "Comments addressed.")

[commit-bot: I haz the power, 2017-01-11 15:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:58:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484150142253720,
"parent_rev": "b2d67f3b752ebf8626ab9bcddd3260aa93d64703", "commit_rev":
"e904894915ff88c5f500fbc1bd816250885ae2d3"}

[commit-bot: I haz the power, 2017-01-11 15:58:09]

Description was changed from

==========
[wasm] (To|From)JSWrappers with I64 params throw a TypeError upon call.

According to the latest spec changes the WasmToJS wrapper and the
JSToWasm wrapper through a TypeError if the signature of the wrapper
contains a I64 parameter or return value. Originally the TypeError was
thrown when the parameter or return value was converted to or from JS.

In addition I removed all special handling of I64 parameters and return
values in the wrappers which was already dead code.

R=titzer@chromium.org
==========

to

==========
[wasm] (To|From)JSWrappers with I64 params throw a TypeError upon call.

According to the latest spec changes the WasmToJS wrapper and the
JSToWasm wrapper through a TypeError if the signature of the wrapper
contains a I64 parameter or return value. Originally the TypeError was
thrown when the parameter or return value was converted to or from JS.

In addition I removed all special handling of I64 parameters and return
values in the wrappers which was already dead code.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2626853003
Cr-Commit-Position: refs/heads/master@{#42238}
Committed:
https://chromium.googlesource.com/v8/v8/+/e904894915ff88c5f500fbc1bd816250885...
==========

[commit-bot: I haz the power, 2017-01-11 15:58:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e904894915ff88c5f500fbc1bd816250885...