Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2626843006: Plugins: Remove left over references to chrome://plugins (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
Bernhard Bauer, Nico, dcheng
CC:
chromium-reviews, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugins: Remove left over references to chrome://plugins Removes the chrome://plugins link from the Disabled Plugin placeholder. It doesn't work anymore. BUG=615738 Review-Url: https://codereview.chromium.org/2626843006 Cr-Commit-Position: refs/heads/master@{#443581} Committed: https://chromium.googlesource.com/chromium/src/+/cc44547a90acfb170c5a52be637009c6940745ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -78 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/renderer/resources/plugins/disabled_plugin.html View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
tommycli
bauerb, thakis, dcheng: PTAL, thanks!! bauerb: chrome/browser/plugins/plugin_info_message_filter.cc chrome/browser/plugins/plugin_observer.cc chrome/browser/plugins/plugin_observer.h thakis: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h chrome/browser/plugins/plugin_info_message_filter.cc chrome/browser/plugins/plugin_observer.cc chrome/browser/plugins/plugin_observer.h ...
3 years, 11 months ago (2017-01-12 20:33:51 UTC) #7
dcheng
ipc removal lgtm
3 years, 11 months ago (2017-01-12 22:13:18 UTC) #10
Nico
lgtm
3 years, 11 months ago (2017-01-13 01:33:59 UTC) #11
Bernhard Bauer
lgtm
3 years, 11 months ago (2017-01-13 11:34:59 UTC) #12
tommycli
thanks all!
3 years, 11 months ago (2017-01-13 16:43:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626843006/1
3 years, 11 months ago (2017-01-13 16:43:59 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 16:52:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc44547a90acfb170c5a52be6370...

Powered by Google App Engine
This is Rietveld 408576698