Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2626813002: Add trivial unit-tests for WTF assertion macros. (Closed)

Created:
3 years, 11 months ago by Wez
Modified:
3 years, 11 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add trivial unit-tests for WTF assertion macros. Assertion.h provides macros active only in Debug builds, but also ones active in all builds, including ones used to crash out on when security- sensitive conditions are violated, so it's important to test they work as intended. Review-Url: https://codereview.chromium.org/2626813002 Cr-Commit-Position: refs/heads/master@{#442717} Committed: https://chromium.googlesource.com/chromium/src/+/c86a9031e0eb3e568b17d840fc7e6c3eb67b2a9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M third_party/WebKit/Source/wtf/AssertionsTest.cpp View 2 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Wez
PTAL :)
3 years, 11 months ago (2017-01-10 22:04:47 UTC) #4
Wez
-esprehn, +tkent who seems to be more blame'd!
3 years, 11 months ago (2017-01-10 22:05:33 UTC) #6
esprehn
lgtm
3 years, 11 months ago (2017-01-10 22:08:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626813002/1
3 years, 11 months ago (2017-01-10 22:09:01 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 22:56:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c86a9031e0eb3e568b17d840fc7e...

Powered by Google App Engine
This is Rietveld 408576698