[promises] Remove unneeded PromiseCreate function from promise.js

[promises] Remove unneeded PromiseCreate function from promise.js

This function was only needed for extrasUtils. Since it was simply
calling a builtin function, just expose that builtin instead. This
requires an arguments adapter frame for the builtin. As a drive-by
fix, also added an arguments adapter for the extrasUtils.resolvePromise
(and a regression test).

Other cleanup: removed unused native context slot for PROMISE_SET_AND_CREATE.

R=gsathya@chromium.org
BUG=v8:5343
Review-Url: https://codereview.chromium.org/2626793003
Cr-Commit-Position: refs/heads/master@{#42284}
Committed: https://chromium.googlesource.com/v8/v8/+/a0e3a8ee89c940e66ccafa6d4e9ee664d91e9a3b

[adamk, 2017-01-10 22:54:47]

adamk@chromium.org changed reviewers:
+ jochen@chromium.org

[adamk, 2017-01-10 22:54:47]

+jochen for his thoughts on this use of extrasUtils

[gsathya, 2017-01-10 22:59:07]

lgtm

[jochen (gone - plz use gerrit), 2017-01-11 09:52:38]

jochen@chromium.org changed reviewers:
+ domenic@chromium.org

[jochen (gone - plz use gerrit), 2017-01-11 09:52:39]

won't that break the v8 extras used by chromium?

[adamk, 2017-01-11 17:41:22]

On 2017/01/11 09:52:39, jochen wrote:
> won't that break the v8 extras used by chromium?

Nothing is broken here, the only slightly weird thing is that instead of
wrapping the kPromiseInternalConstructor builtin function with another JS
function, I'm changing  kPromiseInternalConstructor to act like any other JS
function (and giving it a name). Just wondering if that's the right tradeoff, or
if we would rather have a totally separate function identity.

[domenic, 2017-01-11 17:57:17]

It looks like the createPromise util moved to bootstrapper.cc so that's why
nothing broke. This appears to have already happened for resolvePromise in some
past CL.

Also the V8 extras tests are all still passing so we know things are fine :).

[gsathya, 2017-01-11 17:58:35]

Description was changed from

==========
[promises] Remove unneeded PromiseCreate function from promise.js

This function was only needed for extrasUtils. Since it was simply
calling a builtin function, just expose that builtin instead. This
requires an arguments adapter frame for the builtin. As a drive-by
fix, also added an arguments adapter for the extrasUtils.resolvePromise
(and a regression test).

Other cleanup: removed unused native context slot for PROMISE_SET_AND_CREATE.

R=gsathya@chromium.org
BUG=v8:5046
==========

to

==========
[promises] Remove unneeded PromiseCreate function from promise.js

This function was only needed for extrasUtils. Since it was simply
calling a builtin function, just expose that builtin instead. This
requires an arguments adapter frame for the builtin. As a drive-by
fix, also added an arguments adapter for the extrasUtils.resolvePromise
(and a regression test).

Other cleanup: removed unused native context slot for PROMISE_SET_AND_CREATE.

R=gsathya@chromium.org
BUG=v8:5343
==========

[jochen (gone - plz use gerrit), 2017-01-12 08:32:08]

lgtm

[adamk, 2017-01-12 18:26:22]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:26:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 18:57:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484245582579970, "parent_rev":
"166ed9690144565367600c6b008a61c82aad36c6", "commit_rev":
"a0e3a8ee89c940e66ccafa6d4e9ee664d91e9a3b"}

[commit-bot: I haz the power, 2017-01-12 18:57:54]

Description was changed from

==========
[promises] Remove unneeded PromiseCreate function from promise.js

This function was only needed for extrasUtils. Since it was simply
calling a builtin function, just expose that builtin instead. This
requires an arguments adapter frame for the builtin. As a drive-by
fix, also added an arguments adapter for the extrasUtils.resolvePromise
(and a regression test).

Other cleanup: removed unused native context slot for PROMISE_SET_AND_CREATE.

R=gsathya@chromium.org
BUG=v8:5343
==========

to

==========
[promises] Remove unneeded PromiseCreate function from promise.js

This function was only needed for extrasUtils. Since it was simply
calling a builtin function, just expose that builtin instead. This
requires an arguments adapter frame for the builtin. As a drive-by
fix, also added an arguments adapter for the extrasUtils.resolvePromise
(and a regression test).

Other cleanup: removed unused native context slot for PROMISE_SET_AND_CREATE.

R=gsathya@chromium.org
BUG=v8:5343

Review-Url: https://codereview.chromium.org/2626793003
Cr-Commit-Position: refs/heads/master@{#42284}
Committed:
https://chromium.googlesource.com/v8/v8/+/a0e3a8ee89c940e66ccafa6d4e9ee664d91...
==========

[commit-bot: I haz the power, 2017-01-12 18:57:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a0e3a8ee89c940e66ccafa6d4e9ee664d91...