Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2626743002: Shape Detection: resolve with empty results if any input element's dimension is zero (Closed)

Created:
3 years, 11 months ago by mcasas
Modified:
3 years, 11 months ago
Reviewers:
haraken, xianglu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shape Detection: resolve with empty results if any input element's dimension is zero This CL homogenises the behaviour of the ShapeDetector's detect() in case of an input element with any zero dimension. Assuming such input element pass the cross origin test and its underlying pixel data can be retrieved, then if either width or height is zero, detect() Promise is resolved with an empty array. LayoutTests are adapted/extended/cleaned up. BUG=674306 Review-Url: https://codereview.chromium.org/2626743002 Cr-Commit-Position: refs/heads/master@{#442737} Committed: https://chromium.googlesource.com/chromium/src/+/abcbc58fa094efca8d7b46d6b6537c37b0e90e63

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html View 1 chunk +42 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
mcasas
xianglu@ PTAL
3 years, 11 months ago (2017-01-10 20:39:46 UTC) #4
xianglu
LGTM.
3 years, 11 months ago (2017-01-10 21:15:37 UTC) #5
mcasas
haraken@ RS plz
3 years, 11 months ago (2017-01-10 21:41:29 UTC) #7
haraken
LGTM
3 years, 11 months ago (2017-01-10 23:58:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626743002/20001
3 years, 11 months ago (2017-01-11 00:05:42 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 00:12:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/abcbc58fa094efca8d7b46d6b653...

Powered by Google App Engine
This is Rietveld 408576698