Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2626723003: Revert "Introduce ViewRoot forwarding input/view events to native" (Closed)

Created:
3 years, 11 months ago by Jinsuk Kim
Modified:
3 years, 11 months ago
CC:
aelias_OOO_until_Jul13, agrieve+watch_chromium.org, anandc+watch-blimp_chromium.org, android-webview-reviews_chromium.org, bgoldman+watch-blimp_chromium.org, chromium-reviews, darin-cc_chromium.org, donnd+watch_chromium.org, dtrainor+watch-blimp_chromium.org, feature-vr-reviews_chromium.org, gcasto+watch-blimp_chromium.org, jam, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mdjones+watch_chromium.org, nona+watch_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, shuchen+watch_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Introduce ViewRoot forwarding input/view events to native" This is to fix the reported bug before branching. Will reintroduce this together with what's being handled in https://crrev.com/2595263002. This reverts commit 603de249d822522b152b29184be793550695f2c8. BUG=671967, 671401 TBR=boliu@chromium.org, tedchoc@chromium.org, dtrainor@chromium.org, bshe@chromium.org Review-Url: https://codereview.chromium.org/2626723003 Cr-Commit-Position: refs/heads/master@{#442752} Committed: https://chromium.googlesource.com/chromium/src/+/66a531490d960df0f12bd6dbb3e1957a04b1516e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -323 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 6 chunks +1 line, -13 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_view_impl_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 4 chunks +1 line, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 3 chunks +2 lines, -7 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 4 chunks +21 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 4 chunks +33 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 4 chunks +3 lines, -7 lines 0 comments Download
M ui/android/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
D ui/android/java/src/org/chromium/ui/base/ViewRoot.java View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java View 3 chunks +1 line, -13 lines 0 comments Download
M ui/android/ui_android_jni_registrar.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/view_android.h View 4 chunks +3 lines, -32 lines 0 comments Download
M ui/android/view_android.cc View 6 chunks +10 lines, -103 lines 0 comments Download
D ui/android/view_client.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/android/view_client.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/android/window_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/android/window_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Jinsuk Kim
bshe@chromium.org: Please review changes in chrome/../VrShellImpl.java boliu@chromium.org: Please review changes in content/ dtrainor@chromium.org: Please review ...
3 years, 11 months ago (2017-01-11 00:50:58 UTC) #7
aelias_OOO_until_Jul13
Note that it's fine to use TBR= line for reverts, even if the patch landed ...
3 years, 11 months ago (2017-01-11 00:55:53 UTC) #9
boliu
On 2017/01/11 00:55:53, aelias wrote: > Note that it's fine to use TBR= line for ...
3 years, 11 months ago (2017-01-11 00:58:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626723003/1
3 years, 11 months ago (2017-01-11 01:12:07 UTC) #13
Jinsuk Kim
On 2017/01/11 00:58:31, boliu wrote: > On 2017/01/11 00:55:53, aelias wrote: > > Note that ...
3 years, 11 months ago (2017-01-11 01:16:53 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 01:18:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66a531490d960df0f12bd6dbb3e1...

Powered by Google App Engine
This is Rietveld 408576698