Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Issue 2626723002: Remove some string IDS' _NEW_STYLE suffix and some unused IDS. (Closed)

Created:
3 years, 11 months ago by MAD
Modified:
3 years, 11 months ago
Reviewers:
Georges Khalil
CC:
chromium-reviews, tfarina, sync-reviews_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some string IDS' _NEW_STYLE suffix and some unused IDS. String IDS changes only so, TBR'ing owners. // For chrome/browser/ui/cocoa TBR=asvitkine // for TBR=msw BUG=660349 Review-Url: https://codereview.chromium.org/2626723002 Cr-Commit-Position: refs/heads/master@{#442735} Committed: https://chromium.googlesource.com/chromium/src/+/41afe676df04303cb9b0f67e4765b150969d3899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -64 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +4 lines, -21 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +4 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
MAD
Simple cleanup bug to get me reacquainted to the Chrome development process. Thanks! BYE MAD
3 years, 11 months ago (2017-01-10 20:28:48 UTC) #4
Georges Khalil
LGTM PS: Welcome back :)
3 years, 11 months ago (2017-01-10 21:43:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626723002/1
3 years, 11 months ago (2017-01-10 21:47:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/338787)
3 years, 11 months ago (2017-01-10 21:55:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626723002/1
3 years, 11 months ago (2017-01-10 23:12:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/338891)
3 years, 11 months ago (2017-01-10 23:21:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626723002/1
3 years, 11 months ago (2017-01-10 23:48:20 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 23:54:38 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41afe676df04303cb9b0f67e4765...

Powered by Google App Engine
This is Rietveld 408576698