Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2626713002:
[Linux DomKey] Map |Eisu_Shift| and |Eisu_toggle| to "Alphanumeric" (Closed)
Description[Linux DomKey] Map |Eisu_Shift| and |Eisu_toggle| to "Alphanumeric"
This CL maps keysym |Eisu_Shift| and |Eisu_toggle| to DomKey "Alphanumeric"
as they are used to enter alphanumeric character input mode of IME.
Note:
We shouldn't use DomKey "Eisu" as it's a special key on Mac and has different
functionality. See bug for more details.
BUG=613156
Review-Url: https://codereview.chromium.org/2626713002
Cr-Commit-Position: refs/heads/master@{#450973}
Committed: https://chromium.googlesource.com/chromium/src/+/2d737b644509dd214ab18d8435956ec43a43f4d6
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Eisu_Shift and Eisu_toggle should map to Alphanumeric BUG=613156 ========== to ========== [DomKey] Map |Eisu_Shift| and |Eisu_toggle| to "Alphanumeric" This CL maps keysym |Eisu_Shift| and |Eisu_toggle| to DomKey "Alphanumeric" as they are used to enter alphanumeric character input mode of IME. Note: We shouldn't use DomKey "Eisu" as it's a special key on Mac and has different functionality. See bug for more details. BUG=613156 ==========
chongz@chromium.org changed reviewers: + garykac@chromium.org
garykac@ I didn't find info about these two keysym on the spec, PTAL, thanks!
Description was changed from ========== [DomKey] Map |Eisu_Shift| and |Eisu_toggle| to "Alphanumeric" This CL maps keysym |Eisu_Shift| and |Eisu_toggle| to DomKey "Alphanumeric" as they are used to enter alphanumeric character input mode of IME. Note: We shouldn't use DomKey "Eisu" as it's a special key on Mac and has different functionality. See bug for more details. BUG=613156 ========== to ========== [Linux DomKey] Map |Eisu_Shift| and |Eisu_toggle| to "Alphanumeric" This CL maps keysym |Eisu_Shift| and |Eisu_toggle| to DomKey "Alphanumeric" as they are used to enter alphanumeric character input mode of IME. Note: We shouldn't use DomKey "Eisu" as it's a special key on Mac and has different functionality. See bug for more details. BUG=613156 ==========
On 2017/01/10 21:03:41, chongz wrote: > garykac@ I didn't find info about these two keysym on the spec, PTAL, thanks! garykac@ Can you take a look at this CL please? Thanks!
On 2017/01/13 16:29:38, chongz wrote: > On 2017/01/10 21:03:41, chongz wrote: > > garykac@ I didn't find info about these two keysym on the spec, PTAL, thanks! > > garykac@ Can you take a look at this CL please? Thanks! garykac@ PTAL, thanks.
The CQ bit was checked by garykac@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by chongz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487257755824230, "parent_rev":
"5989961e2951701ff4a2d74bde290a0d26b45370", "commit_rev":
"2d737b644509dd214ab18d8435956ec43a43f4d6"}
Message was sent while issue was closed.
Description was changed from ========== [Linux DomKey] Map |Eisu_Shift| and |Eisu_toggle| to "Alphanumeric" This CL maps keysym |Eisu_Shift| and |Eisu_toggle| to DomKey "Alphanumeric" as they are used to enter alphanumeric character input mode of IME. Note: We shouldn't use DomKey "Eisu" as it's a special key on Mac and has different functionality. See bug for more details. BUG=613156 ========== to ========== [Linux DomKey] Map |Eisu_Shift| and |Eisu_toggle| to "Alphanumeric" This CL maps keysym |Eisu_Shift| and |Eisu_toggle| to DomKey "Alphanumeric" as they are used to enter alphanumeric character input mode of IME. Note: We shouldn't use DomKey "Eisu" as it's a special key on Mac and has different functionality. See bug for more details. BUG=613156 Review-Url: https://codereview.chromium.org/2626713002 Cr-Commit-Position: refs/heads/master@{#450973} Committed: https://chromium.googlesource.com/chromium/src/+/2d737b644509dd214ab18d843595... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2d737b644509dd214ab18d843595... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
