Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2626693002: [wasm] add WebAssembly.instantiate (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] add WebAssembly.instantiate BUG=v8:5816 Review-Url: https://codereview.chromium.org/2626693002 Cr-Commit-Position: refs/heads/master@{#42206} Committed: https://chromium.googlesource.com/v8/v8/+/96ddbf5bbeefb3dd99b5240d3e15d05bfd532d16

Patch Set 1 #

Patch Set 2 : [wasm] add WebAssembly.instantiate #

Patch Set 3 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -31 lines) Patch
M src/wasm/wasm-js.cc View 1 2 5 chunks +91 lines, -27 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 2 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Mircea Trofin
More tests to follow under js-api.js. This CL just ensures we have the right plumbing ...
3 years, 11 months ago (2017-01-10 23:57:39 UTC) #15
bradnelson
lgtm
3 years, 11 months ago (2017-01-11 01:12:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626693002/40001
3 years, 11 months ago (2017-01-11 01:12:25 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 01:14:25 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/96ddbf5bbeefb3dd99b5240d3e15d05bfd5...

Powered by Google App Engine
This is Rietveld 408576698