Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2626683002: Revert of Make helpful announcement when there's no focus (Closed)

Created:
3 years, 11 months ago by David Tseng
Modified:
3 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make helpful announcement when there's no focus (patchset #1 id:1 of https://codereview.chromium.org/2585943002/ ) Reason for revert: Interferes with ARC++; blocked on native ARC++ ChromeVox support. BUG=679760 Original issue's description: > Make helpful announcement when there's no focus > > BUG=638705 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/c689031affc2246cb94c98a707d5ab7c7b737993 > Cr-Commit-Position: refs/heads/master@{#439606} TBR=dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638705 Review-Url: https://codereview.chromium.org/2626683002 Cr-Commit-Position: refs/heads/master@{#442642} Committed: https://chromium.googlesource.com/chromium/src/+/66685f193a5fa700d2c4beb53e99ed12dc5ad9cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
David Tseng
Created Revert of Make helpful announcement when there's no focus
3 years, 11 months ago (2017-01-10 17:55:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626683002/1
3 years, 11 months ago (2017-01-10 17:55:22 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:00:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66685f193a5fa700d2c4beb53e99...

Powered by Google App Engine
This is Rietveld 408576698