Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2626653002: Remove computeLibrarySourceErrors(). (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove computeLibrarySourceErrors(). All errors are computed and validated in assertErrors(). In a 3 tests assertErrors() for the library was mved before the call for a part to ensure library/part link establishment. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b5c5c1c222c75c69cb2a302a676c5e5910cbf867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1709 lines) Patch
M pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 41 chunks +0 lines, -43 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 442 chunks +2 lines, -484 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 17 chunks +0 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 275 chunks +0 lines, -278 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 444 chunks +1 line, -466 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 88 chunks +0 lines, -92 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 16 chunks +0 lines, -16 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 4 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 30 chunks +0 lines, -30 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 245 chunks +2 lines, -263 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-10 16:37:47 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-10 16:42:21 UTC) #2
scheglov
3 years, 11 months ago (2017-01-10 16:44:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5c5c1c222c75c69cb2a302a676c5e5910cbf867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698