Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analyzer/test/generated/static_warning_code_test.dart

Issue 2626653002: Remove computeLibrarySourceErrors(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/static_type_warning_code_test.dart ('k') | pkg/analyzer/test/generated/strong_mode_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/static_warning_code_test.dart
diff --git a/pkg/analyzer/test/generated/static_warning_code_test.dart b/pkg/analyzer/test/generated/static_warning_code_test.dart
index 1fc56f4e0828d3ede8be48c2418337911c737159..aead8aeb1c54b166c62a02fb25b17321a6b2c6dc 100644
--- a/pkg/analyzer/test/generated/static_warning_code_test.dart
+++ b/pkg/analyzer/test/generated/static_warning_code_test.dart
@@ -31,7 +31,6 @@ g(C c) {
print(h('s'));
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -39,7 +38,6 @@ g(C c) {
void fail_undefinedGetter() {
Source source = addSource(r'''
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_GETTER]);
verify([source]);
}
@@ -49,7 +47,6 @@ g(C c) {
/** [m] xxx [new B.c] */
class A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.UNDEFINED_IDENTIFIER,
StaticWarningCode.UNDEFINED_IDENTIFIER
@@ -62,7 +59,6 @@ class C {}
f(var p) {
C.m = 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_SETTER]);
verify([source]);
}
@@ -82,7 +78,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -101,7 +96,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.AMBIGUOUS_IMPORT,
CompileTimeErrorCode.EXTENDS_NON_CLASS
@@ -123,7 +117,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.AMBIGUOUS_IMPORT,
CompileTimeErrorCode.IMPLEMENTS_NON_CLASS
@@ -151,7 +144,7 @@ class N {}''');
r'''
part of lib;
class A extends N {}''');
- computeLibrarySourceErrors(source);
+ assertNoErrors(source);
assertErrors(partSource, [
StaticWarningCode.AMBIGUOUS_IMPORT,
CompileTimeErrorCode.EXTENDS_NON_CLASS
@@ -174,7 +167,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -193,7 +185,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -212,7 +203,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -239,7 +229,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.AMBIGUOUS_IMPORT,
StaticWarningCode.AMBIGUOUS_IMPORT,
@@ -267,7 +256,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -287,7 +275,6 @@ class N {}''');
r'''
library lib2;
class N {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -307,7 +294,6 @@ var v;''');
r'''
library lib2;
var v;''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -326,7 +312,6 @@ var v;''');
r'''
library lib2;
var v;''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -348,7 +333,6 @@ f() {}''');
r'''
library lib2;
f() {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.AMBIGUOUS_IMPORT]);
}
@@ -369,7 +353,6 @@ f() {
library lib2;
class _A {}
g(h(_A a)) {}''');
- computeLibrarySourceErrors(source);
// The name _A is private to the library it's defined in, so this is a type
// mismatch. Furthermore, the error message should mention both _A and the
// filenames so the user can figure out what's going on.
@@ -391,7 +374,6 @@ class A {
@A.fromInt('0')
main() {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -404,7 +386,6 @@ class A {
@A('0')
main() {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -417,7 +398,6 @@ class A {
f(A a) {
a + '0';
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -436,7 +416,6 @@ main() {
A a = new A();
a.. ma().mb(0);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -449,7 +428,6 @@ class A {
main() {
const A(42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE,
CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH
@@ -465,7 +443,6 @@ class A {
class B extends A {
const B() : super(42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -475,7 +452,6 @@ class B extends A {
main() {
(int x) {} ('');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -488,7 +464,6 @@ class A {
f(A a) {
a['0'];
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -501,7 +476,6 @@ class A {
f(A a) {
a('0');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -515,7 +489,6 @@ main() {
A a = new A();
a('0');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -525,7 +498,6 @@ main() {
a(b(int p)) {
b('0');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -537,7 +509,6 @@ class A<K, V> {
f(v);
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -549,7 +520,6 @@ void funNumBool(bool b) {}
main() {
acceptFunNumOptBool(funNumBool);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -562,7 +532,6 @@ class A<T> {
f(A<String> a) {
a.m(1);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -573,7 +542,6 @@ f({String p}) {}
main() {
f(p: 42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -584,7 +552,6 @@ f([String p]) {}
main() {
f(42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -595,7 +562,6 @@ f(String p) {}
main() {
f(42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -606,7 +572,6 @@ typedef A<T>(T p);
f(A<int> a) {
a('1');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -619,7 +584,6 @@ main() {
A a = getA();
a('1');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -630,7 +594,6 @@ typedef A(int p);
f(A a) {
a('1');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -643,7 +606,6 @@ class A<T> {
main() {
new A<String>(42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -656,7 +618,6 @@ class A {
main() {
new A(42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -669,7 +630,6 @@ class A {
main() {
new A(42);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -681,7 +641,6 @@ main() {
C = null;
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_TYPE]);
}
@@ -693,7 +652,6 @@ class A {
f() {
A.v = 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_CONST]);
verify([source]);
}
@@ -706,7 +664,6 @@ class A {
f() {
A.v += 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_CONST]);
verify([source]);
}
@@ -717,7 +674,6 @@ f() {
const x = 0;
x = 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_CONST]);
verify([source]);
}
@@ -728,7 +684,6 @@ f() {
const x = 0;
x += 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_CONST]);
verify([source]);
}
@@ -740,7 +695,6 @@ main() {
E = null;
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_TYPE]);
}
@@ -753,7 +707,6 @@ f() {
A a = new A();
a.v = 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -767,7 +720,6 @@ f() {
A a = new A();
a.v += 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -778,7 +730,6 @@ f() {
final x = 0;
x = 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -789,7 +740,6 @@ f() {
final x = 0;
x += 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -800,7 +750,6 @@ f() {
final x = 0;
x--;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -811,7 +760,6 @@ f() {
final x = 0;
x++;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -822,7 +770,6 @@ f() {
final x = 0;
--x;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -833,7 +780,6 @@ f() {
final x = 0;
++x;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -844,7 +790,6 @@ f() {
final x = 0;
x--;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -855,7 +800,6 @@ f() {
final x = 0;
x++;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -864,7 +808,6 @@ f() {
Source source = addSource(r'''
final x = 0;
f() { x = 1; }''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL]);
verify([source]);
}
@@ -878,7 +821,6 @@ main() {
A a = new A();
a.x = 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL_NO_SETTER]);
verify([source]);
}
@@ -894,7 +836,6 @@ class B {
main() {
B.a.x = 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FINAL_NO_SETTER]);
verify([source]);
}
@@ -905,7 +846,6 @@ f() {}
main() {
f = null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_FUNCTION]);
verify([source]);
}
@@ -918,7 +858,6 @@ class A {
f(A a) {
a.m = () {};
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_METHOD]);
verify([source]);
}
@@ -930,7 +869,6 @@ main() {
F = null;
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_TYPE]);
}
@@ -942,7 +880,6 @@ class C<T> {
}
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ASSIGNMENT_TO_TYPE]);
}
@@ -956,7 +893,6 @@ f(int p) {
break;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.CASE_BLOCK_NOT_TERMINATED]);
verify([source]);
}
@@ -965,7 +901,6 @@ f(int p) {
Source source = addSource(r'''
var A = 0;
f(String s) { var x = s as A; }''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.CAST_TO_NON_TYPE]);
verify([source]);
}
@@ -975,7 +910,6 @@ f(String s) { var x = s as A; }''');
class A {
m();
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.CONCRETE_CLASS_WITH_ABSTRACT_MEMBER]);
verify([source]);
@@ -989,7 +923,6 @@ class I {
class A implements I {
m();
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.CONCRETE_CLASS_WITH_ABSTRACT_MEMBER]);
verify([source]);
@@ -1006,7 +939,6 @@ Stream s;''');
r'''
library lib;
class Future {}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.CONFLICTING_DART_IMPORT]);
}
@@ -1019,7 +951,6 @@ class A {
class B extends A {
var v;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1034,7 +965,6 @@ class A {
class B extends A {
get v => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1049,7 +979,6 @@ class A {
class B extends A {
get v => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1064,7 +993,6 @@ class A {
class B extends A {
get v => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1079,7 +1007,6 @@ class B extends A {}
class C extends B {
get v => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1093,7 +1020,6 @@ class M {
class B extends Object with M {
get v => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1107,7 +1033,6 @@ class A {
class B extends A {
get v => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1119,7 +1044,6 @@ class A {
foo() {}
set foo(a) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER2]);
verify([source]);
@@ -1131,7 +1055,6 @@ class A {
set foo(a) {}
foo() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER]);
verify([source]);
@@ -1145,7 +1068,6 @@ abstract class A {
abstract class B implements A {
foo() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER]);
verify([source]);
@@ -1159,7 +1081,6 @@ class A {
class B extends A {
foo() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER]);
verify([source]);
@@ -1173,7 +1094,6 @@ class A {
class B extends A {
set v(x) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_INSTANCE_SETTER_AND_SUPERCLASS_MEMBER]);
verify([source]);
@@ -1187,7 +1107,6 @@ class A {
class B extends Object with A {
static get x => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_STATIC_GETTER_AND_INSTANCE_SETTER]);
verify([source]);
@@ -1201,7 +1120,6 @@ class A {
class B extends A {
static get x => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_STATIC_GETTER_AND_INSTANCE_SETTER]);
verify([source]);
@@ -1213,7 +1131,6 @@ class A {
static get x => 0;
set x(int p) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_STATIC_GETTER_AND_INSTANCE_SETTER]);
verify([source]);
@@ -1225,7 +1142,6 @@ class A {
get x => 0;
static set x(int p) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_STATIC_SETTER_AND_INSTANCE_MEMBER]);
verify([source]);
@@ -1237,7 +1153,6 @@ class A {
x() {}
static set x(int p) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.CONFLICTING_STATIC_SETTER_AND_INSTANCE_MEMBER]);
verify([source]);
@@ -1251,14 +1166,12 @@ abstract class A {
void f() {
A a = const A();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.CONST_WITH_ABSTRACT_CLASS]);
verify([source]);
}
void test_equalKeysInMap() {
Source source = addSource("var m = {'a' : 0, 'b' : 1, 'a' : 2};");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.EQUAL_KEYS_IN_MAP]);
verify([source]);
}
@@ -1269,7 +1182,6 @@ class A<T> {
const A();
}
var m = {const A<int>(): 0, const A<int>(): 1};''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.EQUAL_KEYS_IN_MAP]);
verify([source]);
}
@@ -1282,7 +1194,6 @@ class A<T> {
const A();
}
var m = {const A<int>(): 0, const A<num>(): 1};''');
- computeLibrarySourceErrors(source);
assertNoErrors(source);
verify([source]);
}
@@ -1294,7 +1205,6 @@ export 'lib1.dart';
export 'lib2.dart';''');
addNamedSource("/lib1.dart", "library lib;");
addNamedSource("/lib2.dart", "library lib;");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.EXPORT_DUPLICATED_LIBRARY_NAMED]);
verify([source]);
}
@@ -1305,7 +1215,6 @@ f() {}
main() {
f(0, 1, '2');
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.EXTRA_POSITIONAL_ARGUMENTS]);
verify([source]);
}
@@ -1315,7 +1224,6 @@ main() {
main() {
(int x) {} (0, 1);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.EXTRA_POSITIONAL_ARGUMENTS]);
verify([source]);
}
@@ -1326,7 +1234,6 @@ class A {
final int x = 0;
A() : x = 1 {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.FIELD_INITIALIZED_IN_INITIALIZER_AND_DECLARATION]);
verify([source]);
@@ -1338,7 +1245,6 @@ class A {
int x;
A() : x = '';
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FIELD_INITIALIZER_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -1349,7 +1255,6 @@ class A {
int x;
A(String this.x) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.FIELD_INITIALIZING_FORMAL_NOT_ASSIGNABLE]);
verify([source]);
@@ -1370,7 +1275,6 @@ class A {
final x = 0;
A() : x = 0 {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.FIELD_INITIALIZED_IN_INITIALIZER_AND_DECLARATION]);
verify([source]);
@@ -1382,7 +1286,6 @@ class A {
final x = 0;
A(this.x) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.FINAL_INITIALIZED_IN_DECLARATION_AND_CONSTRUCTOR]);
verify([source]);
@@ -1394,7 +1297,6 @@ class A {
final int x;
A() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.FINAL_NOT_INITIALIZED_CONSTRUCTOR_1]);
verify([source]);
@@ -1407,7 +1309,6 @@ class A {
final int b;
A() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.FINAL_NOT_INITIALIZED_CONSTRUCTOR_2]);
verify([source]);
@@ -1421,7 +1322,6 @@ class A {
final int c;
A() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.FINAL_NOT_INITIALIZED_CONSTRUCTOR_3_PLUS]);
verify([source]);
@@ -1432,7 +1332,6 @@ class A {
class A {
final F;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FINAL_NOT_INITIALIZED]);
verify([source]);
}
@@ -1442,14 +1341,12 @@ class A {
class A {
static final F;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FINAL_NOT_INITIALIZED]);
verify([source]);
}
void test_finalNotInitialized_library_final() {
Source source = addSource("final F;");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FINAL_NOT_INITIALIZED]);
verify([source]);
}
@@ -1459,7 +1356,6 @@ class A {
f() {
final int x;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FINAL_NOT_INITIALIZED]);
verify([source]);
}
@@ -1468,7 +1364,6 @@ f() {
Source source = addSource(r'''
class A implements Function {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FUNCTION_WITHOUT_CALL]);
verify([source]);
}
@@ -1479,7 +1374,6 @@ abstract class A implements Function {
}
class B extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FUNCTION_WITHOUT_CALL]);
verify([source]);
}
@@ -1490,7 +1384,6 @@ abstract class A implements Function {
}
class B implements A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.FUNCTION_WITHOUT_CALL]);
verify([source]);
}
@@ -1502,7 +1395,6 @@ import 'lib1.dart';
import 'lib2.dart';''');
addNamedSource("/lib1.dart", "library lib;");
addNamedSource("/lib2.dart", "library lib;");
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.IMPORT_DUPLICATED_LIBRARY_NAMED,
HintCode.UNUSED_IMPORT,
@@ -1535,7 +1427,6 @@ abstract class B {
}
class C implements A, B {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.INCONSISTENT_METHOD_INHERITANCE_GETTER_AND_METHOD]);
verify([source]);
@@ -1549,7 +1440,6 @@ class A {
class B extends A {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1566,7 +1456,6 @@ class B extends A {
class C extends B {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1581,7 +1470,6 @@ class A {
class B extends A {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1598,7 +1486,6 @@ class B extends A {
class C extends B {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1617,7 +1504,6 @@ class C extends Base implements Ifc {
foo() {}
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1632,7 +1518,6 @@ class A {
class B extends A {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1649,7 +1534,6 @@ class B extends A {
class C extends B {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1664,7 +1548,6 @@ class A {
class B extends A {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1681,7 +1564,6 @@ class B extends A {
class C extends B {
void n() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INSTANCE_METHOD_NAME_COLLIDES_WITH_SUPERCLASS_STATIC
]);
@@ -1696,7 +1578,6 @@ class A {
class B extends A {
String get g { return 'a'; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_GETTER_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1710,7 +1591,6 @@ class A {
class B extends A {
int f;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INVALID_GETTER_OVERRIDE_RETURN_TYPE,
StaticWarningCode.INVALID_SETTER_OVERRIDE_NORMAL_PARAM_TYPE
@@ -1731,7 +1611,6 @@ abstract class A implements I, J {}
class B extends A {
String get getter => null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_GETTER_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1748,7 +1627,6 @@ abstract class J<V> {
class B implements I<int>, J<String> {
double get g => null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_GETTER_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1762,7 +1640,6 @@ class A {
class B implements A {
m({String a}) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_NAMED_PARAM_TYPE]);
verify([source]);
@@ -1776,7 +1653,6 @@ class A {
class B implements A {
m(String a) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -1790,7 +1666,6 @@ class A {
class B extends A {
m(String a) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -1807,7 +1682,6 @@ abstract class J<V> {
class B extends I<int> implements J<String> {
m(double d) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -1825,7 +1699,6 @@ abstract class A implements I, J {}
class B extends A {
m(String n) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -1843,7 +1716,6 @@ abstract class J<V> {
class B implements I<int>, J<String> {
m(double d) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -1857,7 +1729,6 @@ class A {
class B implements A {
m([String a]) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.INVALID_METHOD_OVERRIDE_OPTIONAL_PARAM_TYPE]);
verify([source]);
@@ -1875,7 +1746,6 @@ abstract class A implements I, J {}
class B extends A {
m([String n]) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.INVALID_METHOD_OVERRIDE_OPTIONAL_PARAM_TYPE]);
verify([source]);
@@ -1889,7 +1759,6 @@ class A {
class B implements A {
String m() { return 'a'; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1905,7 +1774,6 @@ abstract class B implements A {
class C implements B {
String m() { return 'a'; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1919,7 +1787,6 @@ class A {
class B extends Object with A {
String m() { return 'a'; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1933,7 +1800,6 @@ class A {
class B extends A {
String m() { return 'a'; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1949,7 +1815,6 @@ class B extends A {
class C extends B {
String m() { return 'a'; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1967,7 +1832,6 @@ abstract class A implements I, J {}
class B extends A {
String m() => '';
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1981,7 +1845,6 @@ class A {
class B extends A {
void m() {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_METHOD_OVERRIDE_RETURN_TYPE]);
verify([source]);
@@ -1999,7 +1862,6 @@ class B extends A {
foo([x]) {}
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL
]);
@@ -2018,7 +1880,6 @@ class B extends A {
foo({x}) {}
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED]);
verify([source]);
@@ -2037,7 +1898,6 @@ class B extends A {
foo([x]) {}
}
''');
- computeLibrarySourceErrors(source);
assertNoErrors(source);
verify([source]);
}
@@ -2055,7 +1915,6 @@ class B extends A {
foo({x}) {}
}
''');
- computeLibrarySourceErrors(source);
assertNoErrors(source);
verify([source]);
}
@@ -2072,7 +1931,6 @@ class B extends A {
foo([x = 1]) {}
}
''');
- computeLibrarySourceErrors(source);
assertNoErrors(source);
verify([source]);
}
@@ -2089,7 +1947,6 @@ class B extends A {
foo({x: 1}) {}
}
''');
- computeLibrarySourceErrors(source);
assertNoErrors(source);
verify([source]);
}
@@ -2102,7 +1959,6 @@ class A {
class B extends A {
m({int p : 1}) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED]);
verify([source]);
@@ -2116,7 +1972,6 @@ class A {
class B extends A {
m([int p = 1]) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL
]);
@@ -2131,7 +1986,6 @@ class A {
class B extends A {
m({a}) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.INVALID_OVERRIDE_NAMED]);
verify([source]);
}
@@ -2144,7 +1998,6 @@ class A {
class B extends A {
m({a, c}) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.INVALID_OVERRIDE_NAMED]);
verify([source]);
}
@@ -2157,7 +2010,6 @@ class A {
class B extends A {
m([a]) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.INVALID_OVERRIDE_POSITIONAL]);
verify([source]);
}
@@ -2170,7 +2022,6 @@ class A {
class B extends A {
m(a, b, [c]) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.INVALID_OVERRIDE_POSITIONAL]);
verify([source]);
}
@@ -2183,7 +2034,6 @@ class A {
class B extends A {
m(a, [c, d]) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.INVALID_OVERRIDE_POSITIONAL]);
verify([source]);
}
@@ -2196,7 +2046,6 @@ class A {
class B extends A {
m(a, b) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.INVALID_OVERRIDE_REQUIRED]);
verify([source]);
}
@@ -2209,7 +2058,6 @@ class A {
class B extends A {
void set s(String v) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_SETTER_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -2227,7 +2075,6 @@ abstract class A extends I implements J {}
class B extends A {
set setter14(String _) => null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_SETTER_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -2246,7 +2093,6 @@ abstract class A implements I, J {}
class B extends A {
set setter14(String _) => null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_SETTER_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -2263,7 +2109,6 @@ abstract class J<V> {
class B implements I<int>, J<String> {
set s(double d) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.INVALID_SETTER_OVERRIDE_NORMAL_PARAM_TYPE]);
verify([source]);
@@ -2271,21 +2116,18 @@ class B implements I<int>, J<String> {
void test_listElementTypeNotAssignable() {
Source source = addSource("var v = <String> [42];");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.LIST_ELEMENT_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
void test_mapKeyTypeNotAssignable() {
Source source = addSource("var v = <String, int > {1 : 2};");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.MAP_KEY_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
void test_mapValueTypeNotAssignable() {
Source source = addSource("var v = <String, String> {'a' : 2};");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.MAP_VALUE_TYPE_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -2296,7 +2138,6 @@ class A {
int get g { return 0; }
set g(String v) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.MISMATCHED_GETTER_AND_SETTER_TYPES]);
verify([source]);
@@ -2310,7 +2151,6 @@ class A {
class B extends A {
set g(String v) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.MISMATCHED_GETTER_AND_SETTER_TYPES_FROM_SUPERTYPE]);
verify([source]);
@@ -2324,7 +2164,6 @@ class A {
class B extends A {
String get g { return ''; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.MISMATCHED_GETTER_AND_SETTER_TYPES_FROM_SUPERTYPE]);
verify([source]);
@@ -2334,7 +2173,6 @@ class B extends A {
Source source = addSource(r'''
int get g { return 0; }
set g(String v) {}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.MISMATCHED_GETTER_AND_SETTER_TYPES]);
verify([source]);
@@ -2350,7 +2188,6 @@ bool odd(E e) {
}
return false;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.MISSING_ENUM_CONSTANT_IN_SWITCH,
StaticWarningCode.MISSING_ENUM_CONSTANT_IN_SWITCH
@@ -2370,7 +2207,6 @@ class C {
};
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.MIXED_RETURN_TYPES,
StaticWarningCode.MIXED_RETURN_TYPES
@@ -2388,7 +2224,6 @@ class C {
return 0;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.MIXED_RETURN_TYPES,
StaticWarningCode.MIXED_RETURN_TYPES
@@ -2404,7 +2239,6 @@ f(int x) {
}
return 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.MIXED_RETURN_TYPES,
StaticWarningCode.MIXED_RETURN_TYPES
@@ -2418,7 +2252,6 @@ abstract class A {}
void f() {
A a = new A();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NEW_WITH_ABSTRACT_CLASS]);
verify([source]);
}
@@ -2427,7 +2260,6 @@ void f() {
Source source = addSource(r'''
class A {}
f() { return new A<A>(); }''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NEW_WITH_INVALID_TYPE_PARAMETERS]);
verify([source]);
}
@@ -2439,7 +2271,6 @@ class C<K, V> {}
f(p) {
return new C<A>();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NEW_WITH_INVALID_TYPE_PARAMETERS]);
verify([source]);
}
@@ -2451,7 +2282,6 @@ class C<E> {}
f(p) {
return new C<A, A>();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NEW_WITH_INVALID_TYPE_PARAMETERS]);
verify([source]);
}
@@ -2462,7 +2292,6 @@ var A = 0;
void f() {
var a = new A();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NEW_WITH_NON_TYPE]);
verify([source]);
}
@@ -2477,8 +2306,6 @@ void f() {
var a = new lib.A();
}
lib.B b;''');
- computeLibrarySourceErrors(source1);
- computeLibrarySourceErrors(source2);
assertErrors(source2, [StaticWarningCode.NEW_WITH_NON_TYPE]);
verify([source1]);
}
@@ -2491,7 +2318,6 @@ class A {
f() {
new A.name();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NEW_WITH_UNDEFINED_CONSTRUCTOR]);
// no verify(), 'name' is not resolved
}
@@ -2504,7 +2330,6 @@ class A {
f() {
new A();
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.NEW_WITH_UNDEFINED_CONSTRUCTOR_DEFAULT]);
verify([source]);
@@ -2521,7 +2346,6 @@ abstract class A {
}
class C extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [
StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_FIVE_PLUS
]);
@@ -2538,7 +2362,6 @@ abstract class A {
}
class C extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_FOUR]);
verify([source]);
@@ -2554,7 +2377,6 @@ abstract class I {
m();
}
class B = A with M implements I;''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2568,7 +2390,6 @@ abstract class M {
}
abstract class A {}
class B = A with M;''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2583,7 +2404,6 @@ abstract class A {
m();
}
class B = A with M;''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2600,7 +2420,6 @@ abstract class D {
foo(x, [y]);
}
class E extends C implements D {}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2613,7 +2432,6 @@ class I {
}
class C implements I {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2626,7 +2444,6 @@ abstract class A {
}
class C extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2639,7 +2456,6 @@ class I {
}
class C implements I {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2652,7 +2468,6 @@ abstract class A {
}
class C extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2670,7 +2485,6 @@ abstract class B {
}
class C implements A, B {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2682,7 +2496,6 @@ class C implements A, B {
abstract class A { get g1; get g2; }
abstract class B implements A { get g1 => 1; }
class C extends Object with B {}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
}
@@ -2693,7 +2506,6 @@ class C extends Object with B {}''');
abstract class A { m1(); m2(); }
abstract class B implements A { m1() => 1; }
class C extends Object with B {}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
}
@@ -2704,7 +2516,6 @@ class C extends Object with B {}''');
abstract class A { set s1(v); set s2(v); }
abstract class B implements A { set s1(v) {} }
class C extends Object with B {}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
}
@@ -2720,7 +2531,6 @@ abstract class A {
}
class B extends A implements I {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2739,7 +2549,6 @@ abstract class I {
class B extends A implements I {
get field => 0;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2752,7 +2561,6 @@ class I {
}
class C implements I {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2765,7 +2573,6 @@ abstract class A {
}
class C extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2782,7 +2589,6 @@ abstract class B implements A {
}
class C extends B {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2798,7 +2604,6 @@ class I {
class C implements I {
set v(_) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2814,7 +2619,6 @@ class I {
class C implements I {
get v => 1;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE]);
verify([source]);
@@ -2829,7 +2633,6 @@ abstract class A {
}
class C extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_THREE]);
verify([source]);
@@ -2843,7 +2646,6 @@ abstract class A {
}
class C extends A {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_TWO]);
verify([source]);
@@ -2858,7 +2660,6 @@ class I {
}
class C implements I {
}''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_TWO]);
verify([source]);
@@ -2875,7 +2676,6 @@ class A {
class B extends A {}
class C extends Object with B {}
''');
- computeLibrarySourceErrors(source);
assertErrors(source,
[StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_TWO]);
verify([source]);
@@ -2888,7 +2688,6 @@ f() {
} on T catch (e) {
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NON_TYPE_IN_CATCH_CLAUSE]);
verify([source]);
}
@@ -2901,7 +2700,6 @@ f() {
} on T catch (e) {
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NON_TYPE_IN_CATCH_CLAUSE]);
verify([source]);
}
@@ -2911,7 +2709,6 @@ f() {
class A {
int operator []=(a, b) { return a; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NON_VOID_RETURN_FOR_OPERATOR]);
verify([source]);
}
@@ -2921,7 +2718,6 @@ class A {
int set x(int v) {
return 42;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NON_VOID_RETURN_FOR_SETTER]);
verify([source]);
}
@@ -2933,7 +2729,6 @@ class A {
return 42;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NON_VOID_RETURN_FOR_SETTER]);
verify([source]);
}
@@ -2944,7 +2739,6 @@ f() {}
main() {
f v = null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NOT_A_TYPE]);
verify([source]);
}
@@ -2955,7 +2749,6 @@ f(int a, String b) {}
main() {
f();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NOT_ENOUGH_REQUIRED_ARGUMENTS]);
verify([source]);
}
@@ -2965,7 +2758,6 @@ main() {
main() {
(int x) {} ();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NOT_ENOUGH_REQUIRED_ARGUMENTS]);
verify([source]);
}
@@ -2977,7 +2769,6 @@ Getter getter = (x) => x;
main() {
getter();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.NOT_ENOUGH_REQUIRED_ARGUMENTS]);
verify([source]);
}
@@ -2987,7 +2778,6 @@ main() {
library lib;
part 'part.dart';''');
addNamedSource("/part.dart", "part of lub;");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.PART_OF_DIFFERENT_LIBRARY]);
verify([source]);
}
@@ -3000,7 +2790,6 @@ class A implements B {
class B {
factory B() = A;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.REDIRECT_TO_INVALID_FUNCTION_TYPE]);
verify([source]);
}
@@ -3013,7 +2802,6 @@ class A {
class B {
factory B() = A;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.REDIRECT_TO_INVALID_RETURN_TYPE]);
verify([source]);
}
@@ -3026,7 +2814,6 @@ class A implements B{
class B {
factory B() = A.name;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.REDIRECT_TO_MISSING_CONSTRUCTOR]);
}
@@ -3038,7 +2825,6 @@ class A implements B{
class B {
factory B() = A;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.REDIRECT_TO_MISSING_CONSTRUCTOR]);
}
@@ -3048,7 +2834,6 @@ class B {
int A;
factory B() = A;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.REDIRECT_TO_NON_CLASS]);
verify([source]);
}
@@ -3058,7 +2843,6 @@ class B {
class B {
factory B() = A;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.REDIRECT_TO_NON_CLASS]);
verify([source]);
}
@@ -3070,28 +2854,24 @@ Future<int> f() async {
return;
}
''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.RETURN_WITHOUT_VALUE]);
verify([source]);
}
void test_returnWithoutValue_factoryConstructor() {
Source source = addSource("class A { factory A() { return; } }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.RETURN_WITHOUT_VALUE]);
verify([source]);
}
void test_returnWithoutValue_function() {
Source source = addSource("int f() { return; }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.RETURN_WITHOUT_VALUE]);
verify([source]);
}
void test_returnWithoutValue_method() {
Source source = addSource("class A { int m() { return; } }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.RETURN_WITHOUT_VALUE]);
verify([source]);
}
@@ -3106,7 +2886,6 @@ int f(int x) {
}
return;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.RETURN_WITHOUT_VALUE]);
verify([source]);
}
@@ -3119,7 +2898,6 @@ class A {
main() {
A.m();
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.STATIC_ACCESS_TO_INSTANCE_MEMBER]);
verify([source]);
}
@@ -3132,7 +2910,6 @@ class A {
main() {
A.m;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.STATIC_ACCESS_TO_INSTANCE_MEMBER]);
verify([source]);
}
@@ -3145,7 +2922,6 @@ class A {
main() {
A.f;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.STATIC_ACCESS_TO_INSTANCE_MEMBER]);
verify([source]);
}
@@ -3158,7 +2934,6 @@ class A {
main() {
A.f;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.STATIC_ACCESS_TO_INSTANCE_MEMBER]);
verify([source]);
}
@@ -3171,7 +2946,6 @@ class A {
main() {
A.f = 42;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.STATIC_ACCESS_TO_INSTANCE_MEMBER]);
verify([source]);
}
@@ -3183,7 +2957,6 @@ f(int p) {
case 'a': break;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.SWITCH_EXPRESSION_NOT_ASSIGNABLE]);
verify([source]);
}
@@ -3382,7 +3155,6 @@ class A {
}
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_ANNOTATION_GENERIC_FUNCTION_PARAMETER]);
verify([source]);
@@ -3395,7 +3167,6 @@ class A {
return (t is T) ? t : null;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_ANNOTATION_GENERIC_FUNCTION_PARAMETER]);
verify([source]);
@@ -3406,7 +3177,6 @@ class A {
T function<T>(Object t) {
return (t is T) ? t : null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_ANNOTATION_GENERIC_FUNCTION_PARAMETER]);
verify([source]);
@@ -3417,7 +3187,6 @@ T function<T>(Object t) {
class A<K> {
static K k;
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC]);
verify([source]);
@@ -3428,7 +3197,6 @@ class A<K> {
class A<K> {
static K get k => null;
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC]);
verify([source]);
@@ -3441,7 +3209,6 @@ class A<K> {
K k;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC]);
verify([source]);
@@ -3452,7 +3219,6 @@ class A<K> {
class A<K> {
static m(K k) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC]);
verify([source]);
@@ -3463,7 +3229,6 @@ class A<K> {
class A<K> {
static K m() { return null; }
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC]);
verify([source]);
@@ -3474,7 +3239,6 @@ class A<K> {
class A<K> {
static set s(K k) {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(
source, [StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC]);
verify([source]);
@@ -3491,7 +3255,6 @@ main(FuncA f) {
f(new B());
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE]);
}
@@ -3502,7 +3265,6 @@ f(var p) {
if (p is A) {
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.TYPE_TEST_WITH_NON_TYPE]);
verify([source]);
}
@@ -3513,26 +3275,22 @@ f(var p) {
if (p is A) {
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.TYPE_TEST_WITH_UNDEFINED_NAME]);
verify([source]);
}
void test_undefinedClass_instanceCreation() {
Source source = addSource("f() { new C(); }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_CLASS]);
}
void test_undefinedClass_variableDeclaration() {
Source source = addSource("f() { C c; }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_CLASS]);
}
void test_undefinedClassBoolean_variableDeclaration() {
Source source = addSource("f() { boolean v; }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_CLASS_BOOLEAN]);
}
@@ -3545,8 +3303,6 @@ import 'lib.dart' as lib;
void f() {
var g = lib.gg;
}''');
- computeLibrarySourceErrors(source1);
- computeLibrarySourceErrors(source2);
assertErrors(source2, [StaticWarningCode.UNDEFINED_GETTER]);
verify([source1]);
}
@@ -3557,13 +3313,11 @@ f(var l) {
for (e in l) {
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER]);
}
void test_undefinedIdentifier_function() {
Source source = addSource("int a() => b;");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER]);
}
@@ -3574,19 +3328,16 @@ main() {
List;
String;
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER]);
}
void test_undefinedIdentifier_initializer() {
Source source = addSource("var a = b;");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER]);
}
void test_undefinedIdentifier_methodInvocation() {
Source source = addSource("f() { C.m(); }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER]);
}
@@ -3605,7 +3356,6 @@ class B extends A {
var v = _foo;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER]);
}
@@ -3624,13 +3374,11 @@ class B extends A {
_foo = 42;
}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER]);
}
void test_undefinedIdentifierAwait_function() {
Source source = addSource("void a() { await; }");
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_IDENTIFIER_AWAIT]);
}
@@ -3640,13 +3388,12 @@ f({a, b}) {}
main() {
f(c: 1);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.UNDEFINED_NAMED_PARAMETER]);
// no verify(), 'c' is not resolved
}
void test_undefinedSetter() {
- Source source1 = addNamedSource("/lib.dart", "");
+ addNamedSource("/lib.dart", "");
Source source2 = addNamedSource(
"/lib2.dart",
r'''
@@ -3654,8 +3401,6 @@ import 'lib.dart' as lib;
void f() {
lib.gg = null;
}''');
- computeLibrarySourceErrors(source1);
- computeLibrarySourceErrors(source2);
assertErrors(source2, [StaticWarningCode.UNDEFINED_SETTER]);
}
@@ -3665,7 +3410,6 @@ class C {}
f(var p) {
f(C.m);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticTypeWarningCode.UNDEFINED_GETTER]);
}
@@ -3678,7 +3422,6 @@ class C extends S {}
f(var p) {
f(C.g);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticTypeWarningCode.UNDEFINED_GETTER]);
}
@@ -3688,7 +3431,6 @@ class C {}
f(var p) {
f(C.m());
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticTypeWarningCode.UNDEFINED_METHOD]);
}
@@ -3701,7 +3443,6 @@ class C extends S {}
f(var p) {
f(C.m());
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticTypeWarningCode.UNDEFINED_METHOD]);
}
@@ -3714,7 +3455,6 @@ class C extends S {}
f(var p) {
f(C.s = 1);
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticTypeWarningCode.UNDEFINED_SETTER]);
}
@@ -3723,7 +3463,6 @@ f(var p) {
class S {
void get value {}
}''');
- computeLibrarySourceErrors(source);
assertErrors(source, [StaticWarningCode.VOID_RETURN_FOR_GETTER]);
}
}
« no previous file with comments | « pkg/analyzer/test/generated/static_type_warning_code_test.dart ('k') | pkg/analyzer/test/generated/strong_mode_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698