[turbofan] Do Smi comparison without untagging when lowering SpeculativeNumber(Compare).

[turbofan] Do Smi comparison without untagging when lowering SpeculativeNumber(Compare).

BUG=

Review-Url: https://codereview.chromium.org/2626603002
Cr-Commit-Position: refs/heads/master@{#42186}
Committed: https://chromium.googlesource.com/v8/v8/+/bf67ce5f55c8784e3d39d0c823f31dc5c723c63e

[epertoso, 2017-01-10 11:11:22]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 11:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 11:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 11:45:46]

Dry run: This issue passed the CQ dry run.

[epertoso, 2017-01-10 11:48:32]

Description was changed from

==========
[turbofan] Do Smi comparison without untagging when lowering
SpeculativeNumber(Compare).

BUG=
==========

to

==========
[turbofan] Do Smi comparison without untagging when lowering
SpeculativeNumber(Compare).

BUG=
==========

[epertoso, 2017-01-10 11:48:32]

epertoso@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2017-01-10 15:14:16]

lgtm modulo nits. Thanks!

https://codereview.chromium.org/2626603002/diff/20001/src/compiler/simplified...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2626603002/diff/20001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:700: bool InputRepresentationIsTagged(Node*
node) {
It is not really input-specific, so maybe rename to IsNodeRepresentationTagged?

https://codereview.chromium.org/2626603002/diff/20001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:704: representation ==
MachineRepresentation::kTaggedPointer;
return IsAnyTagged(GetInfo(node)->representation());

[epertoso, 2017-01-10 15:18:16]

https://codereview.chromium.org/2626603002/diff/20001/src/compiler/simplified...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2626603002/diff/20001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:700: bool InputRepresentationIsTagged(Node*
node) {
On 2017/01/10 15:14:16, Jarin wrote:
> It is not really input-specific, so maybe rename to
IsNodeRepresentationTagged?

Done.

https://codereview.chromium.org/2626603002/diff/20001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:704: representation ==
MachineRepresentation::kTaggedPointer;
On 2017/01/10 15:14:16, Jarin wrote:
> return IsAnyTagged(GetInfo(node)->representation());

Done.

[epertoso, 2017-01-10 15:18:33]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2017-01-10 15:18:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2626603002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-01-10 15:18:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 15:46:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484061513218380,
"parent_rev": "de2422723435b0a35bbea93fa42fb07ddfed0109", "commit_rev":
"bf67ce5f55c8784e3d39d0c823f31dc5c723c63e"}

[commit-bot: I haz the power, 2017-01-10 15:46:26]

Description was changed from

==========
[turbofan] Do Smi comparison without untagging when lowering
SpeculativeNumber(Compare).

BUG=
==========

to

==========
[turbofan] Do Smi comparison without untagging when lowering
SpeculativeNumber(Compare).

BUG=

Review-Url: https://codereview.chromium.org/2626603002
Cr-Commit-Position: refs/heads/master@{#42186}
Committed:
https://chromium.googlesource.com/v8/v8/+/bf67ce5f55c8784e3d39d0c823f31dc5c72...
==========

[commit-bot: I haz the power, 2017-01-10 15:46:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/bf67ce5f55c8784e3d39d0c823f31dc5c72...