Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 49af60598250bedde6a19356dcf35f020c1bca46..02da384ab391beb80a0514e176fadde016801e11 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -588,7 +588,7 @@ Network.NetworkLogView = class extends UI.VBox {
selectedRequestsNumber++;
selectedTransferSize += requestTransferSize;
}
- if (request.url === request.target().inspectedURL() && request.resourceType() === Common.resourceTypes.Document)
+ if (request.url() === request.target().inspectedURL() && request.resourceType() === Common.resourceTypes.Document)
baseTime = request.startTime;
if (request.endTime > maxTime)
maxTime = request.endTime;
@@ -1599,7 +1599,15 @@ Network.NetworkLogView = class extends UI.VBox {
encapsChars;
}
+ /**
+ * @param {string} str
+ * @return {string}
+ */
function escapeStringPosix(str) {
+ /**
+ * @param {string} x
+ * @return {string}
+ */
function escapeCharacter(x) {
var code = x.charCodeAt(0);
if (code < 256) {
@@ -1629,7 +1637,7 @@ Network.NetworkLogView = class extends UI.VBox {
// (it may be different from the inspected page platform).
var escapeString = platform === 'win' ? escapeStringWin : escapeStringPosix;
- command.push(escapeString(request.url).replace(/[[{}\]]/g, '\\$&'));
+ command.push(escapeString(request.url()).replace(/[[{}\]]/g, '\\$&'));
var inferredMethod = 'GET';
var data = [];

Powered by Google App Engine
This is Rietveld 408576698