third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/ping-response.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html

index a7e4d503efea1283d984d309860b4531f0a5884d..4f9138b6ff3f7b1362adac3b40f27262016ae1c0 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html

@@ -29,7 +29,7 @@ function test()

// Mac, so checking last request.

var request = InspectorTest.networkRequests().pop();

- InspectorTest.addResult(request.url);

+ InspectorTest.addResult(request.url());

InspectorTest.addResult("resource.requestContentType: " + request.requestContentType());

InspectorTest.completeTest();