third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/ping-response.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../network-test.js"></script>	4 <script src="../network-test.js"></script>

5 <script>	5 <script>

6 function onload()	6 function onload()

7 {	7 {

8 if (window.testRunner)	8 if (window.testRunner)

9 testRunner.overridePreference("WebKitHyperlinkAuditingEnabled", 1);	9 testRunner.overridePreference("WebKitHyperlinkAuditingEnabled", 1);

10 runTest();	10 runTest();

(...skipping 11 matching lines...) Expand all Loading...
22 {	22 {

23 InspectorTest.addSniffer(SDK.NetworkDispatcher.prototype, "requestWillBeSent ", step2);	23 InspectorTest.addSniffer(SDK.NetworkDispatcher.prototype, "requestWillBeSent ", step2);

24 InspectorTest.evaluateInPage("navigateLink()");	24 InspectorTest.evaluateInPage("navigateLink()");

25	25

26 function step2()	26 function step2()

27 {	27 {

28 // inspector-test.js appears in network panel occasionally in Safari on	28 // inspector-test.js appears in network panel occasionally in Safari on

29 // Mac, so checking last request.	29 // Mac, so checking last request.

30 var request = InspectorTest.networkRequests().pop();	30 var request = InspectorTest.networkRequests().pop();

31	31

32 InspectorTest.addResult(request.url);	32 InspectorTest.addResult(request.url());

33 InspectorTest.addResult("resource.requestContentType: " + request.reques tContentType());	33 InspectorTest.addResult("resource.requestContentType: " + request.reques tContentType());

34	34

35 InspectorTest.completeTest();	35 InspectorTest.completeTest();

36 }	36 }

37 }	37 }

38 </script>	38 </script>

39 </head>	39 </head>

40 <body onload="onload()">	40 <body onload="onload()">

41 <a id="pingLink" href="#" ping="ping.html">ping</a>	41 <a id="pingLink" href="#" ping="ping.html">ping</a>

42 <p>Tests that hyperlink auditing (ping) requests appear in network panel.</p>	42 <p>Tests that hyperlink auditing (ping) requests appear in network panel.</p>

43 </body>	43 </body>

44 </html>	44 </html>

OLD	NEW