third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-cachedresources-with-same-urls.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html

index f7c91730c96cfe47b18b6b15f5fddd02818f9408..5b6353e71cff0c9c3afed537543ef1808d758249 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html

@@ -56,7 +56,7 @@ function test()

function step5()

{

var request = InspectorTest.networkRequests().pop();

- InspectorTest.addResult("URL:" + request.url);

+ InspectorTest.addResult("URL:" + request.url());

InspectorTest.addResult("from memory cache: " + !!request._fromMemoryCache);

InspectorTest.addResult("from disk cache: " + !!request._fromDiskCache);

InspectorTest.addResult("has timing: " + !!request._timing);

@@ -74,7 +74,7 @@ function test()

function step7()