third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-cachedresources-with-same-urls.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../network-test.js"></script>	4 <script src="../network-test.js"></script>

5 <script src="../debugger-test.js"></script>	5 <script src="../debugger-test.js"></script>

6 <script>	6 <script>

7	7

8 var scriptElement;	8 var scriptElement;

9 function loadScript()	9 function loadScript()

10 {	10 {

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 }	49 }

50	50

51 function step4()	51 function step4()

52 {	52 {

53 InspectorTest.NetworkAgent.setCacheDisabled(true, step5);	53 InspectorTest.NetworkAgent.setCacheDisabled(true, step5);

54 }	54 }

55	55

56 function step5()	56 function step5()

57 {	57 {

58 var request = InspectorTest.networkRequests().pop();	58 var request = InspectorTest.networkRequests().pop();

59 InspectorTest.addResult("URL:" + request.url);	59 InspectorTest.addResult("URL:" + request.url());

60 InspectorTest.addResult("from memory cache: " + !!request._fromMemoryCac he);	60 InspectorTest.addResult("from memory cache: " + !!request._fromMemoryCac he);

61 InspectorTest.addResult("from disk cache: " + !!request._fromDiskCache);	61 InspectorTest.addResult("from disk cache: " + !!request._fromDiskCache);

62 InspectorTest.addResult("has timing: " + !!request._timing);	62 InspectorTest.addResult("has timing: " + !!request._timing);

63 InspectorTest.addResult("");	63 InspectorTest.addResult("");

64 timeZero = request._timing.requestTime;	64 timeZero = request._timing.requestTime;

65 InspectorTest.NetworkAgent.setCacheDisabled(false, step6);	65 InspectorTest.NetworkAgent.setCacheDisabled(false, step6);

66 }	66 }

67	67

68 function step6()	68 function step6()

69 {	69 {

70 InspectorTest.addConsoleSniffer(step7);	70 InspectorTest.addConsoleSniffer(step7);

71 InspectorTest.evaluateInPage("loadScript()");	71 InspectorTest.evaluateInPage("loadScript()");

72 }	72 }

73	73

74 function step7()	74 function step7()

75 {	75 {

76 var request = InspectorTest.networkRequests().pop();	76 var request = InspectorTest.networkRequests().pop();

77 InspectorTest.addResult("URL:" + request.url);	77 InspectorTest.addResult("URL:" + request.url());

78 InspectorTest.addResult("from memory cache: " + !!request._fromMemoryCac he);	78 InspectorTest.addResult("from memory cache: " + !!request._fromMemoryCac he);

79 InspectorTest.addResult("from disk cache: " + !!request._fromDiskCache);	79 InspectorTest.addResult("from disk cache: " + !!request._fromDiskCache);

80 InspectorTest.addResult("has timing: " + !!request._timing);	80 InspectorTest.addResult("has timing: " + !!request._timing);

81 InspectorTest.addResult("");	81 InspectorTest.addResult("");

82 var time = request._timing.requestTime;	82 var time = request._timing.requestTime;

83 InspectorTest.addResult("Second request starts later than first: " + (ti me > timeZero));	83 InspectorTest.addResult("Second request starts later than first: " + (ti me > timeZero));

84 InspectorTest.completeTest();	84 InspectorTest.completeTest();

85 }	85 }

86 }	86 }

87 </script>	87 </script>

88 </head>	88 </head>

89 <body onload="runTest()">	89 <body onload="runTest()">

90 <p> Tests requests loaded from disk cache have correct timing</p>	90 <p> Tests requests loaded from disk cache have correct timing</p>

91 </body>	91 </body>

92 </html>	92 </html>

93	93

OLD	NEW