Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2626533002: Revert of Fix getUserMedia so that failure is reported for invalid audio sources. (Closed)

Created:
3 years, 11 months ago by dewittj
Modified:
3 years, 11 months ago
CC:
avayvod+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jochen+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix getUserMedia so that failure is reported for invalid audio sources. (patchset #2 id:20001 of https://codereview.chromium.org/2623443002/ ) Reason for revert: Revert due to WebRTC tests failing: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56312 [4832:364:0109/131325.673:4351226:ERROR:browser_test_utils.cc(147)] Cannot communicate with DOMMessageQueue. c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(66): error: Value of: ExecuteScriptAndExtractString(shell(), javascript, &result) Actual: false Expected: true Failed to execute javascript callAndRenegotiateToVideo({audio: true}, {audio: true, video:true});. From javascript: (nothing) When executing 'callAndRenegotiateToVideo({audio: true}, {audio: true, video:true});' c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(90): error: Failed and [4704:4156:0109/131352.840:4378402:ERROR:browser_test_utils.cc(147)] Cannot communicate with DOMMessageQueue. c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(66): error: Value of: ExecuteScriptAndExtractString(shell(), javascript, &result) Actual: false Expected: true Failed to execute javascript getUserMediaInIframeAndCloseInSuccessCb({audio: true});. From javascript: (nothing) When executing 'getUserMediaInIframeAndCloseInSuccessCb({audio: true});' c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(90): error: Failed Original issue's description: > Fix getUserMedia so that failure is reported for invalid audio sources. > This changes getUserMedia to wait for initialization of local > audio sources before issuing the completion callback (either success or > failure). > Previously, if an error occurs between attempting to start a local > audio source and the render side OnStreamCreated callback, getUserMedia > would report successful completion with an audio track but no audio > would actually be delivered for that track. > > BUG=679210 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2623443002 > Cr-Commit-Position: refs/heads/master@{#442323} > Committed: https://chromium.googlesource.com/chromium/src/+/81cb66acf3f8099e416c7fc5ecbcaabf6d5c3c04 TBR=jochen@chromium.org,guidou@chromium.org,xhwang@chromium.org,tommi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679210 Review-Url: https://codereview.chromium.org/2626533002 Cr-Commit-Position: refs/heads/master@{#442373} Committed: https://chromium.googlesource.com/chromium/src/+/f05caaa1349e44abd44a00f88506bf140a0bc887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -401 lines) Patch
M chrome/renderer/media/cast_receiver_audio_valve.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/media/cast_receiver_audio_valve.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/media/cast_receiver_session_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/external_media_stream_audio_source.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/external_media_stream_audio_source.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/renderer/media/local_media_stream_audio_source.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/renderer/media/local_media_stream_audio_source.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/media/user_media_client_impl.h View 7 chunks +7 lines, -43 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 10 chunks +106 lines, -191 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 3 chunks +1 line, -18 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source.h View 4 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source_unittest.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M media/audio/audio_input_device.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/audio/audio_input_device_unittest.cc View 3 chunks +0 lines, -53 lines 0 comments Download
M media/base/audio_capturer_source.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dewittj
Created Revert of Fix getUserMedia so that failure is reported for invalid audio sources.
3 years, 11 months ago (2017-01-09 22:23:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626533002/1
3 years, 11 months ago (2017-01-09 22:24:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f05caaa1349e44abd44a00f88506bf140a0bc887
3 years, 11 months ago (2017-01-09 22:26:26 UTC) #6
tommi (sloooow) - chröme
3 years, 11 months ago (2017-01-10 10:41:10 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2622643006/ by tommi@chromium.org.

The reason for reverting is: Preparing reland.

Powered by Google App Engine
This is Rietveld 408576698