components/cronet/android/cronet_impl_common_proguard.cfg - Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_impl_common_proguard.cfg

Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations (Closed)

Patch Set: Addressed Paul's comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/cronet_impl_common_proguard.cfg

diff --git a/components/cronet/android/cronet_impl_common_proguard.cfg b/components/cronet/android/cronet_impl_common_proguard.cfg

index a4ecdcd3f588518b21c9fd9c8c443ab8f9e89042..ff17a34f0ef64afad92b7d5c4ebe7f7ec6b1e8fc 100644

--- a/components/cronet/android/cronet_impl_common_proguard.cfg

+++ b/components/cronet/android/cronet_impl_common_proguard.cfg

@@ -1,10 +1,5 @@

# Proguard config for apps that depend on cronet_impl_common_java.jar.

-# This constructor is called using the reflection from Cronet API (cronet_api.jar).

--keep class org.chromium.net.impl.CronetEngineBuilderImpl {

- public <init>(android.content.Context);

# This class should be explicitly kept to avoid failure if

# class/merging/horizontal proguard optimization is enabled.

--keep class org.chromium.net.impl.ImplVersion

+-keep class org.chromium.net.impl.ImplVersion

pauljensen 2017/01/23 19:42:21 Perhaps not the right question for this CL, but wh

kapishnikov 2017/01/23 22:14:55 That is a good point. Before, it failed to access