components/cronet/android/cronet_impl_common_proguard.cfg - Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/android/cronet_impl_common_proguard.cfg

Issue 2626523003: Cronet: a framework for providing alternative Cronet implementations (Closed)

Patch Set: Addressed Paul's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Proguard config for apps that depend on cronet_impl_common_java.jar.	1 # Proguard config for apps that depend on cronet_impl_common_java.jar.

2	2

3 # This constructor is called using the reflection from Cronet API (cronet_api.ja r).

4 -keep class org.chromium.net.impl.CronetEngineBuilderImpl {

5 public <init>(android.content.Context);

6 }

7

8 # This class should be explicitly kept to avoid failure if	3 # This class should be explicitly kept to avoid failure if

9 # class/merging/horizontal proguard optimization is enabled.	4 # class/merging/horizontal proguard optimization is enabled.

10 -keep class org.chromium.net.impl.ImplVersion	5 -keep class org.chromium.net.impl.ImplVersion
	pauljensen 2017/01/23 19:42:21 Perhaps not the right question for this CL, but wh Perhaps not the right question for this CL, but what is this for? I don't think this class is referened by reflection or anything not explicit. kapishnikov 2017/01/23 22:14:55 That is a good point. Before, it failed to access Show quoted text On 2017/01/23 19:42:21, pauljensen wrote: > Perhaps not the right question for this CL, but what is this for? I don't think > this class is referened by reflection or anything not explicit. That is a good point. Before, it failed to access fields of the class if class/merging/horizontal proguard optimization was enabled. Since this CL added getters and made the fields private, the tests don't fail anymore. I deleted the "keep" but kept the file for the time being.
OLD	NEW