Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2626493002: [pattern rewriter] Dont return value from void function (Closed)

Created:
3 years, 11 months ago by gsathya
Modified:
3 years, 11 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[pattern rewriter] Dont return value from void function R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2626493002 Cr-Commit-Position: refs/heads/master@{#42156} Committed: https://chromium.googlesource.com/v8/v8/+/8d19859c9e07c2b3cedb4c094f53b57272fc484f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parsing/pattern-rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
gsathya
3 years, 11 months ago (2017-01-09 20:00:44 UTC) #3
adamk
lgtm (but note that there are other returns in the same function; there's nothing particularly ...
3 years, 11 months ago (2017-01-09 20:05:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626493002/1
3 years, 11 months ago (2017-01-10 03:05:56 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 03:07:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8d19859c9e07c2b3cedb4c094f53b57272f...

Powered by Google App Engine
This is Rietveld 408576698